Skip to content

Guard packerProc against a missing :packer key on JRuby #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
byroot merged 1 commit into from
Sep 11, 2026
+7 −1
Merged

Guard packerProc against a missing :packer key on JRuby #406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ext/java/org/msgpack/jruby/Factory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ public IRubyObject registerTypeInternal(ThreadContext ctx, IRubyObject type, IRu
extensionRegistry.put(extModule, (int) typeId, recursive, packerProc, unpackerProc);

if (extModule == runtime.getSymbol()) {
hasSymbolExtType = !packerProc.isNil();
hasSymbolExtType = packerProc != null && !packerProc.isNil();
}

if (options != null) {
Expand Down
6 changes: 6 additions & 0 deletions spec/factory_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,6 +273,12 @@ class MyType2 < MyType
expect(factory.load(factory.dump(:foo))).to be == "foo"
end

it 'handles Symbol type registered with only an unpacker' do
factory = MessagePack::Factory.new
factory.register_type(0x00, Symbol, unpacker: :to_sym.to_proc)
expect(factory.load(factory.dump(:foo))).to be == "foo"
end

describe "registering multiple ext type for the same class" do
let(:payload) do
factory = MessagePack::Factory.new
Expand Down
Loading