Skip to content

Add unit tests to cover typeof#205

Merged
josesimoes merged 4 commits into
nanoframework:mainfrom
josesimoes:add-unit-tests-1164
Jun 9, 2023
Merged

Add unit tests to cover typeof#205
josesimoes merged 4 commits into
nanoframework:mainfrom
josesimoes:add-unit-tests-1164

Conversation

@josesimoes

Copy link
Copy Markdown
Member

Description

  • Add unit tests to cover typeof.

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (add new Unit Test(s) or improved existing one(s), has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).
  • I have added new tests to cover my changes.

@Ellerbach Ellerbach left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect :-)

@josesimoes

Copy link
Copy Markdown
Member Author

Unit tests failing. Expected as reported in nanoframework/Home#1164.
Fix in nanoframework/metadata-processor#160.

@sonarqubecloud

sonarqubecloud Bot commented Jun 9, 2023

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@josesimoes josesimoes merged commit 6635c2b into nanoframework:main Jun 9, 2023
@josesimoes josesimoes deleted the add-unit-tests-1164 branch June 9, 2023 00:20
josesimoes added a commit that referenced this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants