Skip to content

Adding nanoFramework.Graphics and nanoFramework.Graphics.Core to friends#207

Merged
josesimoes merged 1 commit into
nanoframework:mainfrom
CoryCharlton:main
Nov 3, 2023
Merged

Adding nanoFramework.Graphics and nanoFramework.Graphics.Core to friends#207
josesimoes merged 1 commit into
nanoframework:mainfrom
CoryCharlton:main

Conversation

@CoryCharlton

Copy link
Copy Markdown
Member

Description

  • Adding nanoFramework.Graphics and nanoFramework.Graphics.Core to friends

Motivation and Context

So they can access MathInternal

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (add new Unit Test(s) or improved existing one(s), has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).
  • I have added new tests to cover my changes.

@sonarqubecloud

sonarqubecloud Bot commented Nov 2, 2023

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@josesimoes josesimoes left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@josesimoes josesimoes merged commit 8e133f2 into nanoframework:main Nov 3, 2023
@CoryCharlton

Copy link
Copy Markdown
Member Author

@josesimoes Does this require manual interaction to get a new version pushed to NuGet? I went to update the reference in nanoFramework.Graphics so I could remove the Mathematics class as part of my PR but I don't see a new version available.

josesimoes pushed a commit that referenced this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants