Skip to content

Adding some unit tests for string#211

Merged
josesimoes merged 2 commits into
nanoframework:mainfrom
CoryCharlton:issue_1404
Nov 11, 2023
Merged

Adding some unit tests for string#211
josesimoes merged 2 commits into
nanoframework:mainfrom
CoryCharlton:issue_1404

Conversation

@CoryCharlton

Copy link
Copy Markdown
Member

Description

Motivation and Context

  • There was no unit test coverage

How Has This Been Tested?

  • Unit tests ;-)

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (add new Unit Test(s) or improved existing one(s), has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).
  • I have added new tests to cover my changes.

@CoryCharlton

Copy link
Copy Markdown
Member Author

@josesimoes The issue was that none of the tests run in my environment due to the following error:

Could not find test executor with URI 'executor://nanoframeworktestexecutor/'. Make sure that the test executor is installed and supports .net runtime version .

I'm assuming this is related to my environment though and I ran these tests in my other repository against a custom firmware build so I'll toss this over.

@josesimoes josesimoes left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are already a bunch of tests for string, no point on scattering them.
Better have these new ones along with those, OK? Sorry for the extra work...

@CoryCharlton

Copy link
Copy Markdown
Member Author

There are already a bunch of tests for string, no point on scattering them. Better have these new ones along with those, OK? Sorry for the extra work...

No worries, I didn't look hard enough (or at all beyond the fact that there was no project with "String" in the name 😛). I moved them.

@josesimoes josesimoes left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thanks. 👍🏻 +1

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@josesimoes josesimoes merged commit 5951d06 into nanoframework:main Nov 11, 2023
@CoryCharlton CoryCharlton deleted the issue_1404 branch November 11, 2023 00:35
josesimoes pushed a commit that referenced this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants