Work on GC APIs#243
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Unit tests failing as expected as the mscorlib native hasn't been implemented yet. |
- Add APIs previsouly in Native.Runtime assembly. - Add `Collect` and `GetTotalMemory` to follow .NET API. - `Run` is now private and used in both the new APIs. - Improve IntelliSense comments. - Rework GC unit tests to take advantage of the new APIs in GC. - Add new Unit test to cover `GetTotalMemory`.
Ellerbach
left a comment
There was a problem hiding this comment.
looks good all up. Indeed, while moving to generics, it's the moment to make breaking changes!
Description
CollectandGetTotalMemoryto follow .NET API.Runis now private and used in both the new APIs.GetTotalMemory.Motivation and Context
GCclass nanoFramework.Runtime.Native#148.How Has This Been Tested?
Screenshots
Types of changes
Checklist: