Improve min max performance and IEEE compliance#151
Merged
Conversation
Member
Author
|
Look like the build failure is because the firmware changes need to be merged first. |
Member
Author
|
For reference: Before...After... |
Member
|
josesimoes
reviewed
Nov 6, 2023
josesimoes
left a comment
Member
There was a problem hiding this comment.
Impressive! Thanks for all the work on this.
Great usage of the benchmark library! 😉
Overall all good. We're better moving the Max and Min to mscorlib.
Even if that's not release rigth away. It won't break anything.
14 tasks
josesimoes
reviewed
Nov 6, 2023
josesimoes
reviewed
Nov 6, 2023
josesimoes
reviewed
Nov 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Math.Max(float)andMath.Min(float)are 3x slower than thedoubleoverloads Home#1395Math.Min(double/float)do not handle NaN correctly Home#1396How Has This Been Tested?
Screenshots
Types of changes
Checklist: