-
Notifications
You must be signed in to change notification settings - Fork 10
docs(claude): migrate workflows out of CLAUDE.md to skills #355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+46
−33
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| --- | ||
| name: create-issue | ||
| description: Draft a GitHub Issue as the spec artifact for Spec-Driven Development (SDD) before implementing a feature or bug fix in this project. | ||
| --- | ||
|
|
||
| This project uses Spec-Driven Development (SDD): discuss in Plan mode first, create a GitHub Issue as the spec artifact, then implement. Always offer to draft an issue before writing code. | ||
|
|
||
| **Feature request** (`enhancement` label): | ||
| - **Problem**: the pain point being solved | ||
| - **Proposed Solution**: expected behavior and functionality | ||
| - **Suggested Approach** *(optional)*: implementation plan if known | ||
| - **Acceptance Criteria**: at minimum — behaves as proposed, tests added/updated, no regressions | ||
| - **References**: related issues, docs, or examples | ||
|
|
||
| **Bug report** (`bug` label): | ||
| - **Description**: clear summary of the bug | ||
| - **Steps to Reproduce**: numbered, minimal steps | ||
| - **Expected / Actual Behavior**: one section each | ||
| - **Environment**: runtime versions + OS | ||
| - **Additional Context**: logs, screenshots, stack traces | ||
| - **Possible Solution** *(optional)*: suggested fix or workaround | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| --- | ||
| name: key-workflows | ||
| description: Step-by-step guides for adding an endpoint or modifying the schema in this Spring Boot project, plus the branch/commit proposal to make after finishing work. | ||
| --- | ||
|
|
||
| **Add an endpoint**: Define DTO in `models/` with Bean Validation → add service method in `services/` with `@Transactional` → create controller endpoint with `@Operation` annotation → add tests → run `./mvnw clean test jacoco:report`. | ||
|
|
||
| **Modify schema**: Create a new Flyway migration `src/main/resources/db/migration/V{N}__description.sql` (production path) → update `@Entity` in `models/Player.java` → update DTOs if API changes → also update `src/test/resources/ddl.sql` and `dml.sql` (tests use Spring SQL init, not Flyway) → update service, repository, and tests → run `./mvnw clean test`. Do not manually edit the SQLite file in `storage/`; Flyway owns it. | ||
|
|
||
| **After completing work**: Suggest a branch name (e.g. `feat/113-add-player-stats`) and a commit message following Conventional Commits including co-author line: | ||
|
|
||
| ```text | ||
| feat(scope): description (#issue) | ||
|
|
||
| Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com> | ||
| ``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Resolve MD041 in both new skill files.
Both files begin their Markdown content with a paragraph after YAML front matter, triggering the same top-level-heading lint warning.
.claude/skills/create-issue/SKILL.md#L1-L6: add a heading such as# Create an issue..claude/skills/key-workflows/SKILL.md#L1-L6: add a heading such as# Key workflows.🧰 Tools
🪛 markdownlint-cli2 (0.23.0)
[warning] 6-6: First line in a file should be a top-level heading
(MD041, first-line-heading, first-line-h1)
📍 Affects 2 files
.claude/skills/create-issue/SKILL.md#L1-L6(this comment).claude/skills/key-workflows/SKILL.md#L1-L6🤖 Prompt for AI Agents
Source: Linters/SAST tools