Skip to content

perf: performance & efficiency sweep (request/storage/refresh hot paths) #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ndycode wants to merge 12 commits into from
Closed

perf: performance & efficiency sweep (request/storage/refresh hot paths) #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
ef16e32
perf: optimize hot request and sync paths
ndycode Mar 4, 2026
bca2742
perf: reduce hot-path fanout and add perf gate
ndycode Mar 4, 2026
05cb605
perf: add refresh and hydration timing metrics
ndycode Mar 4, 2026
526f261
test: harden perf metrics coverage for review quality
ndycode Mar 4, 2026
917d936
test(storage): cover cleanup throttle and in-flight dedup
ndycode Mar 4, 2026
68e12ac
fix(review): close remaining perf-sweep CodeRabbit threads
ndycode Mar 4, 2026
bfdfe6b
chore(ci): retrigger CodeRabbit after transient rate-limit
ndycode Mar 5, 2026
596f48f
fix(pr38): resolve remaining review threads
ndycode Mar 5, 2026
02337db
fix: resolve follow-up PR38 reliability review findings
ndycode Mar 5, 2026
01d6305
fix(pr38): close remaining reliability and test-thread feedback
ndycode Mar 5, 2026
2329352
Fix refresh-guardian index mapping and cleanup race handling
ndycode Mar 5, 2026
462cce6
Handle EACCES as transient stale-artifact cleanup error
ndycode Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,10 @@ jobs:
- name: Build
run: npm run build

- name: Runtime performance regression gate
if: matrix.node-version == '20.x'
run: npm run perf:runtime:ci

lint:
name: Lint

Expand Down
152 changes: 133 additions & 19 deletions index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ import {
createCodexHeaders,
extractRequestUrl,
handleErrorResponse,
handleSuccessResponse,
handleSuccessResponseDetailed,
getUnsupportedCodexModelInfo,
resolveUnsupportedCodexFallbackModel,
refreshAndUpdateToken,
Expand Down Expand Up @@ -251,6 +251,7 @@ export const OpenAIOAuthPlugin: Plugin = async ({ client }: PluginInput) => {
balanced: 15_000,
conservative: 20_000,
};
const HYDRATE_EMAILS_MAX_CONCURRENCY = 4;

const parseFailoverMode = (value: string | undefined): FailoverMode => {
const normalized = (value ?? "").trim().toLowerCase();
Expand Down Expand Up @@ -345,6 +346,14 @@ export const OpenAIOAuthPlugin: Plugin = async ({ client }: PluginInput) => {
streamFailoverRecoveries: number;
streamFailoverCrossAccountRecoveries: number;
cumulativeLatencyMs: number;
emailHydrationRuns: number;
emailHydrationCandidates: number;
emailHydrationRefreshed: number;
emailHydrationUpdated: number;
emailHydrationFailures: number;
emailHydrationCumulativeDurationMs: number;
emailHydrationMaxBatchSize: number;
emailHydrationMaxConcurrencyUsed: number;
lastRequestAt: number | null;
lastError: string | null;
};
Expand All @@ -366,9 +375,42 @@ export const OpenAIOAuthPlugin: Plugin = async ({ client }: PluginInput) => {
streamFailoverRecoveries: 0,
streamFailoverCrossAccountRecoveries: 0,
cumulativeLatencyMs: 0,
emailHydrationRuns: 0,
emailHydrationCandidates: 0,
emailHydrationRefreshed: 0,
emailHydrationUpdated: 0,
emailHydrationFailures: 0,
emailHydrationCumulativeDurationMs: 0,
emailHydrationMaxBatchSize: 0,
emailHydrationMaxConcurrencyUsed: 0,
lastRequestAt: null,
lastError: null,
};
const inFlightAuthRefreshByToken = new Map<string, Promise<OAuthAuthDetails>>();

const refreshAuthWithDedup = async (auth: OAuthAuthDetails): Promise<OAuthAuthDetails> => {
const refreshKey = auth.refresh?.trim();
if (!refreshKey) {
return (await refreshAndUpdateToken(auth, client)) as OAuthAuthDetails;
}
const existing = inFlightAuthRefreshByToken.get(refreshKey);
if (existing) {
return existing;
}
const refreshPromise = (async () => {
const refreshed = (await refreshAndUpdateToken(auth, client)) as OAuthAuthDetails;
return refreshed;
})();
inFlightAuthRefreshByToken.set(refreshKey, refreshPromise);
refreshPromise.finally(() => {
if (inFlightAuthRefreshByToken.get(refreshKey) === refreshPromise) {
inFlightAuthRefreshByToken.delete(refreshKey);
}
}).catch(() => {
// Error propagation is handled by awaiting callers.
});
return refreshPromise;
};
Comment thread
coderabbitai[bot] marked this conversation as resolved.

type TokenSuccess = Extract<TokenResult, { type: "success" }>;
type TokenSuccessWithAccount = TokenSuccess & {
Comment thread
ndycode marked this conversation as resolved.
Expand Down Expand Up @@ -710,11 +752,29 @@ export const OpenAIOAuthPlugin: Plugin = async ({ client }: PluginInput) => {
if (accountsToHydrate.length === 0) return storage;

let changed = false;
await Promise.all(
accountsToHydrate.map(async (account) => {
let refreshedCount = 0;
let failedCount = 0;
let updatedAccountCount = 0;
const hydrateStartedAt = performance.now();
const workerCount = Math.min(
HYDRATE_EMAILS_MAX_CONCURRENCY,
accountsToHydrate.length,
);
let nextHydrateIndex = 0;
const workers = Array.from({ length: workerCount }, async () => {
while (nextHydrateIndex < accountsToHydrate.length) {
const position = nextHydrateIndex;
nextHydrateIndex += 1;
const account = accountsToHydrate[position];
if (!account) continue;
try {
const refreshed = await queuedRefresh(account.refreshToken);
if (refreshed.type !== "success") return;
if (refreshed.type !== "success") {
failedCount += 1;
continue;
}
refreshedCount += 1;
let accountUpdated = false;
const id = extractAccountId(refreshed.access);
const email = sanitizeEmail(extractAccountEmail(refreshed.access, refreshed.idToken));
if (
Expand All @@ -725,28 +785,61 @@ export const OpenAIOAuthPlugin: Plugin = async ({ client }: PluginInput) => {
account.accountId = id;
account.accountIdSource = "token";
changed = true;
accountUpdated = true;
}
if (email && email !== account.email) {
account.email = email;
changed = true;
accountUpdated = true;
}
if (refreshed.access && refreshed.access !== account.accessToken) {
account.accessToken = refreshed.access;
changed = true;
accountUpdated = true;
}
if (typeof refreshed.expires === "number" && refreshed.expires !== account.expiresAt) {
account.expiresAt = refreshed.expires;
changed = true;
accountUpdated = true;
}
if (refreshed.refresh && refreshed.refresh !== account.refreshToken) {
account.refreshToken = refreshed.refresh;
changed = true;
accountUpdated = true;
}
if (accountUpdated) {
updatedAccountCount += 1;
}
} catch {
failedCount += 1;
logWarn(`[${PLUGIN_NAME}] Failed to hydrate email for account`);
}
}),
}
});
await Promise.all(workers);
const durationMs = Math.round(performance.now() - hydrateStartedAt);
runtimeMetrics.emailHydrationRuns += 1;
runtimeMetrics.emailHydrationCandidates += accountsToHydrate.length;
runtimeMetrics.emailHydrationRefreshed += refreshedCount;
runtimeMetrics.emailHydrationUpdated += updatedAccountCount;
runtimeMetrics.emailHydrationFailures += failedCount;
runtimeMetrics.emailHydrationCumulativeDurationMs += durationMs;
runtimeMetrics.emailHydrationMaxBatchSize = Math.max(
runtimeMetrics.emailHydrationMaxBatchSize,
accountsToHydrate.length,
);
runtimeMetrics.emailHydrationMaxConcurrencyUsed = Math.max(
runtimeMetrics.emailHydrationMaxConcurrencyUsed,
workerCount,
);
logDebug("Email hydration pass complete", {
candidates: accountsToHydrate.length,
refreshed: refreshedCount,
updated: updatedAccountCount,
failed: failedCount,
workerCount,
durationMs,
});

if (changed) {
storage.accounts = accountsCopy;
Expand Down Expand Up @@ -1489,10 +1582,7 @@ while (attempted.size < Math.max(1, accountCount)) {
let accountAuth = accountManager.toAuthDetails(account) as OAuthAuthDetails;
try {
if (shouldRefreshToken(accountAuth, tokenRefreshSkewMs)) {
accountAuth = (await refreshAndUpdateToken(
accountAuth,
client,
)) as OAuthAuthDetails;
accountAuth = await refreshAuthWithDedup(accountAuth);
accountManager.updateFromAuth(account, accountAuth);
accountManager.clearAuthFailures(account);
accountManager.saveToDiskDebounced();
Expand Down Expand Up @@ -2122,10 +2212,7 @@ while (attempted.size < Math.max(1, accountCount)) {
let fallbackAuth = accountManager.toAuthDetails(fallbackAccount) as OAuthAuthDetails;
try {
if (shouldRefreshToken(fallbackAuth, tokenRefreshSkewMs)) {
fallbackAuth = (await refreshAndUpdateToken(
fallbackAuth,
client,
)) as OAuthAuthDetails;
fallbackAuth = await refreshAuthWithDedup(fallbackAuth);
accountManager.updateFromAuth(fallbackAccount, fallbackAuth);
accountManager.clearAuthFailures(fallbackAccount);
accountManager.saveToDiskDebounced();
Expand Down Expand Up @@ -2280,15 +2367,19 @@ while (attempted.size < Math.max(1, accountCount)) {
},
);
}
const successResponse = await handleSuccessResponse(responseForSuccess, isStreaming, {
const successResult = await handleSuccessResponseDetailed(responseForSuccess, isStreaming, {
streamStallTimeoutMs,
});
const successResponse = successResult.response;

if (!isStreaming && emptyResponseMaxRetries > 0) {
const clonedResponse = successResponse.clone();
let parsedBody = successResult.parsedBody;
try {
const bodyText = await clonedResponse.text();
const parsedBody = bodyText ? JSON.parse(bodyText) as unknown : null;
if (parsedBody === undefined) {
const clonedResponse = successResponse.clone();
const bodyText = await clonedResponse.text();
parsedBody = bodyText ? JSON.parse(bodyText) as unknown : null;
}
if (isEmptyResponse(parsedBody)) {
if (emptyResponseRetries < emptyResponseMaxRetries) {
emptyResponseRetries++;
Expand Down Expand Up @@ -3736,6 +3827,13 @@ while (attempted.size < Math.max(1, accountCount)) {
successful > 0
? Math.round(runtimeMetrics.cumulativeLatencyMs / successful)
: 0;
const avgEmailHydrationDurationMs =
runtimeMetrics.emailHydrationRuns > 0
? Math.round(
runtimeMetrics.emailHydrationCumulativeDurationMs /
runtimeMetrics.emailHydrationRuns,
)
: 0;
const liveSyncSnapshot = liveAccountSync?.getSnapshot();
const guardianStats = refreshGuardian?.getStats();
const sessionAffinityEntries = sessionAffinityStore?.size() ?? 0;
Expand Down Expand Up @@ -3764,9 +3862,17 @@ while (attempted.size < Math.max(1, accountCount)) {
`Stream failover recoveries: ${runtimeMetrics.streamFailoverRecoveries}`,
`Stream failover cross-account recoveries: ${runtimeMetrics.streamFailoverCrossAccountRecoveries}`,
`Empty-response retries: ${runtimeMetrics.emptyResponseRetries}`,
`Email hydration runs: ${runtimeMetrics.emailHydrationRuns}`,
`Email hydration candidates: ${runtimeMetrics.emailHydrationCandidates}`,
`Email hydration refreshed: ${runtimeMetrics.emailHydrationRefreshed}`,
`Email hydration updated: ${runtimeMetrics.emailHydrationUpdated}`,
`Email hydration failures: ${runtimeMetrics.emailHydrationFailures}`,
`Email hydration avg duration: ${avgEmailHydrationDurationMs}ms`,
`Email hydration max batch size: ${runtimeMetrics.emailHydrationMaxBatchSize}`,
`Email hydration max concurrency used: ${runtimeMetrics.emailHydrationMaxConcurrencyUsed}`,
`Session affinity entries: ${sessionAffinityEntries}`,
`Live sync: ${liveSyncSnapshot?.running ? "on" : "off"} (${liveSyncSnapshot?.reloadCount ?? 0} reloads)`,
`Refresh guardian: ${guardianStats ? "on" : "off"} (${guardianStats?.refreshed ?? 0} refreshed, ${guardianStats?.failed ?? 0} failed)`,
`Refresh guardian: ${guardianStats ? "on" : "off"} (${guardianStats?.refreshed ?? 0} refreshed, ${guardianStats?.failed ?? 0} failed, avg tick ${guardianStats?.avgTickDurationMs ?? 0}ms)`,
`Last upstream request: ${lastRequest}`,
];

Expand Down Expand Up @@ -3799,6 +3905,14 @@ while (attempted.size < Math.max(1, accountCount)) {
"accent",
),
formatUiKeyValue(ui, "Empty-response retries", String(runtimeMetrics.emptyResponseRetries), "warning"),
formatUiKeyValue(ui, "Email hydration runs", String(runtimeMetrics.emailHydrationRuns), "muted"),
formatUiKeyValue(ui, "Email hydration candidates", String(runtimeMetrics.emailHydrationCandidates), "muted"),
formatUiKeyValue(ui, "Email hydration refreshed", String(runtimeMetrics.emailHydrationRefreshed), "success"),
formatUiKeyValue(ui, "Email hydration updated", String(runtimeMetrics.emailHydrationUpdated), "accent"),
formatUiKeyValue(ui, "Email hydration failures", String(runtimeMetrics.emailHydrationFailures), "warning"),
formatUiKeyValue(ui, "Email hydration avg duration", `${avgEmailHydrationDurationMs}ms`, "muted"),
formatUiKeyValue(ui, "Email hydration max batch size", String(runtimeMetrics.emailHydrationMaxBatchSize), "muted"),
formatUiKeyValue(ui, "Email hydration max concurrency used", String(runtimeMetrics.emailHydrationMaxConcurrencyUsed), "muted"),
formatUiKeyValue(ui, "Session affinity entries", String(sessionAffinityEntries), "muted"),
formatUiKeyValue(
ui,
Expand All @@ -3810,7 +3924,7 @@ while (attempted.size < Math.max(1, accountCount)) {
ui,
"Refresh guardian",
guardianStats
? `on (${guardianStats.refreshed} refreshed, ${guardianStats.failed} failed)`
? `on (${guardianStats.refreshed} refreshed, ${guardianStats.failed} failed, avg tick ${guardianStats.avgTickDurationMs}ms)`
: "off",
guardianStats ? "success" : "muted",
),
Expand Down
Loading