Skip to content

test(codex): give the shutdown regressions a timeout longer than their own bounds #649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ndycode merged 1 commit into from
Aug 2, 2026
Merged

test(codex): give the shutdown regressions a timeout longer than their own bounds #649

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion test/codex-bin-wrapper.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -669,6 +669,14 @@ function runWrapper(
// time a stuck wrapper would otherwise block for.
const WRAPPER_SHUTDOWN_TIMEOUT_MS = 12_000;

// Vitest's default per-test timeout is 5s, which is *shorter* than the bound
// above. Without an explicit per-test timeout, a stuck wrapper would be killed
// by Vitest at 5s and reported as a bare "Test timed out" — the diagnostic the
// spawn bound exists to produce would never be printed. The shutdown tests must
// therefore outlast their own internal bounds: `spawnSync` (12s) plus the
// process-exit polling below.
const SHUTDOWN_TEST_TIMEOUT_MS = 30_000;

function expectWrapperReturned(
result: SpawnSyncReturns<string>,
what: string,
Expand Down Expand Up @@ -3202,7 +3210,7 @@ describe("codex bin wrapper", () => {
expectWrapperReturned(result, "a leaked grandchild still holds its stdio");
expect(result.status).toBe(3);
expect(elapsedMs).toBeLessThan(WRAPPER_SHUTDOWN_TIMEOUT_MS);
});
}, SHUTDOWN_TEST_TIMEOUT_MS);

// POSIX only: the launcher must escalate to SIGKILL when the helper ignores the
// graceful SIGTERM. On Windows `kill()` is always an unconditional terminate, so
Expand Down Expand Up @@ -3268,6 +3276,7 @@ describe("codex bin wrapper", () => {
}
expect(isProcessAlive(helperPid)).toBe(false);
},
SHUTDOWN_TEST_TIMEOUT_MS,
);

// Canonical-home routing drops the per-session shadow copy, so two concurrent
Expand Down