chore(deps): clear the high-severity advisories blocking audit:ci - #650
Conversation
`npm run audit:ci` has been failing, so the CI security gate would not pass. Two production dependencies and two transitive dev dependencies carried high-severity advisories. Production: - hono 4.12.21 -> 4.12.33, clearing GHSA-hvrm-45r6-mjfj (JSX context not isolated per request) and GHSA-w62v-xxxg-mg59 (XSS via the cx() escaping bypass), both reaching <=4.12.26. Bumped in dependencies and in the override, which is also what @openauthjs/openauth resolves through. - undici 6.25.0 -> 6.28.0, clearing Set-Cookie header injection, WebSocket fragment DoS, keep-alive response-queue poisoning, and the SameSite downgrade (all <=6.26.0). Stays on the 6.x line: 7.x raises the runtime floor to Node 20 and this package still publishes engines.node >=18.17.0. Dev-only, pinned via overrides in the style already used for rollup and minimatch, since both are transitive: - brace-expansion 5.0.9 (ReDoS in >=2.0.0 <2.1.3 and >=4.0.0 <5.0.8) - postcss 8.5.25 (<=8.5.17, reaching the dev graph through Vite) SECURITY.md documents each pin's rationale and is machine-checked against package.json by test/documentation.test.ts, so it is updated in the same commit. `npm run audit:ci` now exits 0 and `npm audit --omit=dev` reports no vulnerabilities. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0139f4WZCmWykXZcdEmWTusj
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
📜 Recent review details⏰ Context from checks skipped due to timeout. (1)
🧰 Additional context used📓 Path-based instructions (2)**/*📄 CodeRabbit inference engine (AGENTS.md)
Files:
package.json📄 CodeRabbit inference engine (README.md)
Files:
🧠 Learnings (1)📓 Common learnings🔇 Additional comments (5)
📝 Walkthroughminor security maintenance. production dependencies
Walkthroughupdated security-related dependency pins in Changesdependency security updates
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
A corrective release. No new features and no configuration changes. Patch rather than minor: 2.8.0 was minor because it changed where the official CLI keeps its state. This one only corrects behaviour that was already meant to work, adds no settings, and writes nothing new to disk — the same shape as 2.7.1. mcodex resume and mcodex fork hung on a blank TUI whenever runtime rotation was enabled. Both are interactive TUI entry points that carry a forwarded subcommand, so 2.8.0's interactive classification — which matched only an invocation with no subcommand — missed them and left them on the shadow home, whose mirror deliberately omits the runtime SQLite state. Both now use the canonical-home transport, with rotation still enabled. The wrapper could also fail to return to the shell after an interrupted or non-zero exit, because helper shutdown left the detached helper's pipes referenced. Shutdown is now bounded and releases those handles. Separately, --help no longer starts a rotation transport for any request command. Also clears four high-severity advisories that were failing npm run audit:ci: hono 4.12.21 -> 4.12.33 and undici 6.25.0 -> 6.28.0, plus brace-expansion and postcss pinned through overrides for the dev graph. Closes ndycode#647. Landed as ndycode#648, ndycode#649, and ndycode#650. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0139f4WZCmWykXZcdEmWTusj
Summary
npm run audit:ci— a CI gate — has been failing. This clears it.What Changed
Production:
honoGHSA-hvrm-45r6-mjfj(JSX context not isolated per request),GHSA-w62v-xxxg-mg59(XSS viacx()escaping bypass) — both reach<=4.12.26undiciGHSA-p88m-4jfj-68fv,GHSA-vxpw-j846-p89q,GHSA-35p6-xmwp-9g52,GHSA-g8m3-5g58-fq7m(Set-Cookie header injection, WebSocket fragment DoS, keep-alive response-queue poisoning, SameSite downgrade) — all reach<=6.26.0honois bumped in bothdependenciesandoverrides; the override is what@openauthjs/openauthresolves through, and npm rejects the install if the two disagree.undicideliberately stays on the6.xline.7.xraises the runtime floor to Node 20 and this package still publishesengines.node >=18.17.0—6.28.0is the first6.xrelease clear of all four advisories.Dev-only, pinned via
overridesin the style already used forrollupandminimatch, since both are transitive:brace-expansion→5.0.9(ReDoS in>=2.0.0 <2.1.3and>=4.0.0 <5.0.8)postcss→8.5.25(<=8.5.17, reaching the dev graph through Vite)SECURITY.mddocuments each pin's rationale and is machine-checked againstpackage.jsonbytest/documentation.test.ts— that test caught the drift, so the doc is updated in the same commit.Validation
npm run audit:ci→ exits 0 (was exiting 1)npm audit --omit=dev --audit-level=high→found 0 vulnerabilitiesnpm run lintnpm run typechecknpm test— 5288 passed, 4 skipped, 0 failednpm run buildnpm test -- test/lockfile-version-floor.test.tsRisk and Rollback
undiciis the only runtime HTTP dependency and backs the rotation proxy's dispatch path, so it is the one to watch; it stays within6.xand the full suite passes. The other three are a patch bump and two dev-only pins.Additional Notes
Worth knowing separately: this repo's GitHub Actions have never actually executed —
ci.ymlhas zero runs and recent workflow runs sit queued for days — soaudit:cifailing had never surfaced anywhere. The gate is only meaningful once Actions runs.note: greptile review for oc-chatgpt-multi-auth. cite files like
lib/foo.ts:123. confirm regression tests + windows concurrency/token redaction coverage.Greptile Summary
this pr updates production and development dependency pins to clear high-severity audit findings while preserving node 18 production support.
Confidence Score: 5/5
the pr appears safe to merge, with no concrete changed-code failure identified.
the runtime packages remain within compatible major versions, the development overrides resolve the current toolchain, and the lockfile and security documentation remain synchronized.
Important Files Changed
Reviews (1): Last reviewed commit: "chore(deps): clear the high-severity adv..." | Re-trigger Greptile
Context used: