Skip to content

Extend cisco_ios set_boot_options method#311

Merged
jeffkala merged 4 commits into
developfrom
fix_no_boot_options
Sep 13, 2024
Merged

Extend cisco_ios set_boot_options method#311
jeffkala merged 4 commits into
developfrom
fix_no_boot_options

Conversation

@pszulczewski

Copy link
Copy Markdown
Contributor

No description provided.

@pszulczewski pszulczewski linked an issue Feb 22, 2024 that may be closed by this pull request
@jvanderaa

Copy link
Copy Markdown
Contributor

@pszulczewski thoughts on this?

@pszulczewski

pszulczewski commented Aug 29, 2024

Copy link
Copy Markdown
Contributor Author

@jvanderaa yes, there was a test to fix therefore this PR was in Draft ... and has been forgotten :).
Now the test is fixed and I went one step further to refresh poetry lock, which reveled some linting issues.
Whoever is going to review, bear in mind that the first commit is to fix the issue. Second commit is fixing the unit test, the rest is linting, caused by poetry.lock update.

@pszulczewski pszulczewski marked this pull request as ready for review August 29, 2024 10:34
@jeffkala jeffkala merged commit 6cd4e38 into develop Sep 13, 2024
@jeffkala jeffkala deleted the fix_no_boot_options branch September 13, 2024 20:39
@jeffkala jeffkala restored the fix_no_boot_options branch December 6, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3750 IOS Boot Options don't meet the current code checks

4 participants