Skip to content

Fix user info route#21

Merged
AndyScherzinger merged 2 commits into
masterfrom
userInfoRouteUpdate
Oct 21, 2016
Merged

Fix user info route#21
AndyScherzinger merged 2 commits into
masterfrom
userInfoRouteUpdate

Conversation

@AndyScherzinger

@AndyScherzinger AndyScherzinger commented Oct 18, 2016

Copy link
Copy Markdown
Member

Resolves #18

I`ll test drive this first. As described in #18 this is an important change since the legacy URL won't work anymore for Nextcloud 11+

cc @tobiasKaminsky

@AndyScherzinger AndyScherzinger added this to the NC Android lib 1.0.8 milestone Oct 18, 2016
@AndyScherzinger AndyScherzinger mentioned this pull request Oct 18, 2016
@AndyScherzinger

Copy link
Copy Markdown
Member Author

I tested the changed route info and it works for my server (where the old URL worked) and for the demo account that has been given to us for the server where the login didn't work and now that one works too.

@tobiasKaminsky please review and merge 😃 🚀

@AndyScherzinger

Copy link
Copy Markdown
Member Author

@tobiasKaminsky this will automatically be in your next beta release since I pushed it to the lib's beta branch

@tobiasKaminsky

Copy link
Copy Markdown
Member

👍

@tobiasKaminsky

Copy link
Copy Markdown
Member

@AndyScherzinger we need a second 👍 here ;)

@AndyScherzinger

Copy link
Copy Markdown
Member Author

👍

@AndyScherzinger

Copy link
Copy Markdown
Member Author

@jancborchardt @LukasReschke can you please 👍 :)

@AndyScherzinger

Copy link
Copy Markdown
Member Author

You can merge @tobiasKaminsky

@jancborchardt

Copy link
Copy Markdown
Member

Can’t say anything here ;D @LukasReschke maybe

@jancborchardt

Copy link
Copy Markdown
Member

@AndyScherzinger or do you mean to bypass the merging 2 +1s? I can add you both as admins for the android and android-library repos.

@jancborchardt

Copy link
Copy Markdown
Member

Ah, you already are. :)

@AndyScherzinger

Copy link
Copy Markdown
Member Author

Bypass the 2 👍s

@AndyScherzinger

Copy link
Copy Markdown
Member Author

Works as expected and beta feedback is also positive. So merging.

@AndyScherzinger AndyScherzinger merged commit efbbb16 into master Oct 21, 2016
@AndyScherzinger AndyScherzinger deleted the userInfoRouteUpdate branch October 21, 2016 20:22
surinder-tsys added a commit to nextmcloud/android-library that referenced this pull request Mar 1, 2023
…actions/cirrus-actions/rebase-1.7

Bump cirrus-actions/rebase from 1.5 to 1.7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants