Correctly update file after sharing#11775
Closed
tobiasKaminsky wants to merge 2 commits into
Closed
Conversation
Member
Author
|
/backport to stable-3.25 |
ZetaTom
reviewed
Jun 26, 2023
surinder-tsys
added a commit
to nextmcloud/android
that referenced
this pull request
Jun 28, 2023
1 task
surinder-tsys
added a commit
to nextmcloud/android
that referenced
this pull request
Aug 28, 2023
surinder-tsys
added a commit
to nextmcloud/android
that referenced
this pull request
Oct 18, 2023
surinder-tsys
added a commit
to nextmcloud/android
that referenced
this pull request
Oct 20, 2023
tobiasKaminsky
force-pushed
the
updateShareIcon
branch
2 times, most recently
from
4c86520 to
09a7c8c
Compare
tobiasKaminsky
requested review from
JonasMayerDev,
ZetaTom and
alperozturk96
alperozturk96
approved these changes
Nov 20, 2023
Member
Author
|
/rebase |
nextcloud-command
force-pushed
the
updateShareIcon
branch
from
09a7c8c to
9c9d577
Compare
ZetaTom
approved these changes
Nov 21, 2023
surinder-tsys
added a commit
to nextmcloud/android
that referenced
this pull request
Jan 10, 2024
surinder-tsys
added a commit
to nextmcloud/android
that referenced
this pull request
Feb 8, 2024
surinder-tsys
added a commit
to nextmcloud/android
that referenced
this pull request
Feb 14, 2024
AndyScherzinger
force-pushed
the
updateShareIcon
branch
from
9c9d577 to
08a8ef3
Compare
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
…apter.java Co-authored-by: Tom <70907959+ZetaTom@users.noreply.github.com> Signed-off-by: Tobias Kaminsky <tobias@nextcloud.com> Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
AndyScherzinger
force-pushed
the
updateShareIcon
branch
from
08a8ef3 to
3e5d887
Compare
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/11775.apk |
|
blue-Light-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/11775-Screenshot-blue-Light-20-27 |
github-actions Bot
pushed a commit
to nextmcloud/android
that referenced
this pull request
May 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step to reproduce:
Actual result:
Share-Icon is remain same . When refresh the page then icon gets change as link icon
Expected result:
Icon should get change after link share from its popup