Skip to content

Improve perform credential update#17040

Open
alperozturk96 wants to merge 2 commits into
masterfrom
improve-perform-credential-update
Open

Improve perform credential update#17040
alperozturk96 wants to merge 2 commits into
masterfrom
improve-perform-credential-update

Conversation

@alperozturk96

@alperozturk96 alperozturk96 commented May 13, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions

github-actions Bot commented May 13, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/25784967548/artifacts/6964439258
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@alperozturk96
Rename .java to .kt
53a81ab 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
improve check remote wipe task
ca5caf8 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96 alperozturk96 force-pushed the improve-perform-credential-update branch from 4e83c3e to ca5caf8 Compare June 10, 2026 09:57
alperozturk96
alperozturk96 commented Jun 10, 2026
View reviewed changes
Comment thread app/src/main/java/com/owncloud/android/ui/activity/FileActivity.java
@@ -481,37 +477,6 @@ protected void requestCredentialsUpdate(Account account) {
new CheckRemoteWipeTask(backgroundJobManager, account, new WeakReference<>(this)).execute();

@alperozturk96 alperozturk96 Jun 10, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CheckRemoteWipeRemoteOperation()

This always returns false on master and in this PR. Do you know why? @tobiasKaminsky ?

This PR not changes any behaviour but during my test I found this.

@github-actions

github-actions Bot commented Jun 10, 2026

Copy link
Copy Markdown

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@github-actions

github-actions Bot commented Jun 10, 2026

Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice3333
Correctness6766
Dodgy code215215
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness3131
Performance4141
Security1616
Total413412

@github-actions

github-actions Bot commented Jun 10, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/27268391237/artifacts/7533412007
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

3. to review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@alperozturk96