Allow icon-only and clear-at-only status updates - #17562
ibrahim-iqbal wants to merge 1 commit into
Conversation
197b973 to
25c2da7
Compare
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
| // even when the caller is only changing the icon or clearAt. Fall | ||
| // back to a single space so those single-field updates go through. | ||
| // Matches the fix applied in nextcloud/talk-android@a89c5952fa. |
There was a problem hiding this comment.
| // even when the caller is only changing the icon or clearAt. Fall | |
| // back to a single space so those single-field updates go through. | |
| // Matches the fix applied in nextcloud/talk-android@a89c5952fa. |
The server rejects a status update whose message field is empty, even when the caller is only changing the icon or clearAt. Substitute a single space so those single-field updates go through. Fixes nextcloud#9855 Signed-off-by: ibrahim-iqbal <ibrahim-iqbal@users.noreply.github.com>
25c2da7 to
1ba0a8e
Compare
|
Pushed
The other failing checks on the previous head ( |
3 participants
Fixes #9855.
The server rejects a status update whose message field is empty, even when the caller is only changing the icon or the clear-at time. That silently blocks the "only icon" and "only clear at" paths from the status dialog.
Substituting a single space when the input is empty lets the API accept those single-field updates, matching the fix that was already applied on the talk-android side: nextcloud/talk-android@a89c5952fa.
Repro (from the issue)
Before: dialog closes but neither the icon nor the clear-at value is persisted.
After: the chosen icon and/or clear-at is stored server-side; the message field shows as a single space, which is what talk-android has been shipping for the same reason.