Skip to content

Add service discovery to reverse proxy doc#1297

Merged
MorrisJobke merged 1 commit into
masterfrom
proxy-service-discovery
Apr 1, 2019
Merged

Add service discovery to reverse proxy doc#1297
MorrisJobke merged 1 commit into
masterfrom
proxy-service-discovery

Conversation

@kesselb

@kesselb kesselb commented Mar 10, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@kesselb

kesselb commented Mar 10, 2019

Copy link
Copy Markdown
Contributor Author

@MorrisJobke could you share a screenshot of the final version? I can't build it locally.

@MorrisJobke

Copy link
Copy Markdown
Member

I can't build it locally.

Mind to troubleshot this?

I guess the install instructions are just way off.

Typically it consist of those steps:

  1. Install pipenv - https://pipenv.readthedocs.io/en/latest/
  2. Create a Python 2 environment (typically inside the documentation repo): pipenv --two
  3. Change into the environment: pipenv shell
  4. Install the dependencies pip install -r requirements.txt
  5. Now you can use make ... to build all the stuff

@kesselb Mind to update the readme with that info?

@MorrisJobke

Copy link
Copy Markdown
Member

@kesselb Mind to update the readme with that info?

#1299

@MorrisJobke

Copy link
Copy Markdown
Member

Bildschirmfoto 2019-03-12 um 10 22 53

@kesselb kesselb force-pushed the proxy-service-discovery branch from 47f8768 to 2f1a919 Compare March 31, 2019 13:25
@kesselb kesselb marked this pull request as ready for review March 31, 2019 13:25
@kesselb kesselb requested a review from MorrisJobke March 31, 2019 13:26

@MorrisJobke MorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and makes sense 👍

@MorrisJobke MorrisJobke merged commit 4da83a5 into master Apr 1, 2019
@MorrisJobke MorrisJobke deleted the proxy-service-discovery branch April 1, 2019 10:02
@MorrisJobke

Copy link
Copy Markdown
Member

/backport to stable15

@backportbot-nextcloud

Copy link
Copy Markdown

backport to stable15 in #1343

@kesselb

kesselb commented Apr 1, 2019

Copy link
Copy Markdown
Contributor Author

Ok. I hope someone from the community can share an example for nginx.

@MorrisJobke

Copy link
Copy Markdown
Member

Ok. I hope someone from the community can share an example for nginx.

It is already in the Nginx config: https://docs.nextcloud.com/server/stable/admin_manual/installation/nginx.html?highlight=nginx#nextcloud-in-a-subdir-of-nginx

    location = /.well-known/carddav {
      return 301 $scheme://$host/nextcloud/remote.php/dav;
    }
    location = /.well-known/caldav {
      return 301 $scheme://$host/nextcloud/remote.php/dav;
    }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants