fix(a11y): announce form submission success to screen readers#3238
Merged
Conversation
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
pringelmann
added
a11y
pringelmann
requested review from
Chartman123,
artonge and
susnux
and removed request for
Chartman123
Chartman123
approved these changes
Mar 23, 2026
susnux
reviewed
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After submitting a form, screen readers had no way to know the submission succeeded — the success view rendered silently. This adds a visually-hidden
aria-liveregion that announces the success message.The live region is populated via a watcher with a short delay (100ms) because the submission triggers a large DOM change (form replaced by success view) that causes screen readers to miss a synchronous
aria-live="polite"update.Not addressed here
The remaining issues from #2858 (checkbox keyboard toggle, date picker keyboard nav, dropdown announcements) are tracked separately:
nextcloud-vue@nextcloud/vuev9 migration (refactor: Migrate components for Vue 3 compatibility #2972), which replaces the underlyingvue2-datepickerwith@vuepic/vue-datepickerNcSelect) screen reader announcements: upstream issue innextcloud-vueAn alternative approach worth considering for the success announcement is using
showSuccess()from@nextcloud/dialogs, which handles its own screen reader announcements. The tradeoff is it also shows a visible toast to sighted users.Checklist