Skip to content

PHP 7.0 is end of life#12819

Merged
rullzer merged 1 commit into
masterfrom
feature/noid/bump-eol-version-of-php
Dec 4, 2018
Merged

PHP 7.0 is end of life#12819
rullzer merged 1 commit into
masterfrom
feature/noid/bump-eol-version-of-php

Conversation

@MorrisJobke

Copy link
Copy Markdown
Member

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke MorrisJobke added the 3. to review Waiting for reviews label Dec 4, 2018
@MorrisJobke MorrisJobke added this to the Nextcloud 16 milestone Dec 4, 2018
@MorrisJobke

Copy link
Copy Markdown
Member Author

/backport to stable15

@nickvergessen

Copy link
Copy Markdown
Member

Weeeeell , yes for master, no for backport?

@MorrisJobke

Copy link
Copy Markdown
Member Author

Weeeeell , yes for master, no for backport?

We should show it at least in 15. Also the PHP doc says so:

/*
 * Whether the php version is still supported (at time of release)
 * according to: https://secure.php.net/supported-versions.php

@MorrisJobke

Copy link
Copy Markdown
Member Author

And to clarify: this is only an entry in the setup checks of the admin settings.

@nickvergessen

Copy link
Copy Markdown
Member

And to clarify: this is only an entry in the setup checks of the admin settings.

Ah okay, I thought the check in base.php, fine then

@xf-

xf- commented Dec 4, 2018

Copy link
Copy Markdown

I'm no fan of EOL versions, but major distributions like Debian stretch provide only 7.0 and no Backport of 7.1 or 7.2. Buster will release with 7.2 or/and 7.3
https://packages.debian.org/search?keywords=php

@MorrisJobke

MorrisJobke commented Dec 4, 2018

Copy link
Copy Markdown
Member Author

I'm no fan of EOL versions, but major distributions like Debian stretch provide only 7.0 and no Backport of 7.1 or 7.2. Buster will release with 7.2 or/and 7.3

Nevertheless we need to tell administrators that they run a version that is not officially supported. I don't want to start a discussion about distributions and that they maybe back port fixes. This is about giving the admin the opportunity to plan for the future and see where potential problems could occur. We need to upgrade our dependencies as well and run into problems because they don't support PHP 7.0 anymore. (see #12021)

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 4, 2018
@MorrisJobke

Copy link
Copy Markdown
Member Author

This is how it looks like:

bildschirmfoto 2018-12-04 um 16 07 37

@rullzer rullzer merged commit 6c1a3a6 into master Dec 4, 2018
@rullzer rullzer deleted the feature/noid/bump-eol-version-of-php branch December 4, 2018 19:11
@backportbot-nextcloud

Copy link
Copy Markdown

backport to stable15 in #12830

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants