returns a 404 instead of exception if app is not installed - #13088#13134
Merged
Conversation
Member
Author
|
backport to 15 will be needed |
Member
|
I guess we should adjust the setup check in the same run, it probably still fails if a 404 code is returned. |
Member
|
/backport to stable15 |
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
force-pushed
the
bugfix/13088/404-instead-of-exception
branch
from
deefb9e to
a3be286
Compare
Member
|
As discussed with @daita we use a 501 Not implemented now, so we can properly check if the url rewrite is properly setup even if there is no app hooking into the webfinger endpoint. |
Member
|
Would be good to get this in, so we probably can get the backport for stable15 in 15.0.1. |
Member
|
/backport to stable15 |
|
backport to stable15 in #13357 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13088