Skip to content

Add caching headers for public previews#13326

Merged
MorrisJobke merged 1 commit into
masterfrom
bugfix/13290/cache-public-preview
Jan 3, 2019
Merged

Add caching headers for public previews#13326
MorrisJobke merged 1 commit into
masterfrom
bugfix/13290/cache-public-preview

Conversation

@juliusknorr

Copy link
Copy Markdown
Member

This adds proper caching headers to public image previews.

Fixes #13290

Signed-off-by: Julius Härtl <jus@bitgrid.net>

@rullzer rullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well yes. Good point.

@MorrisJobke

Copy link
Copy Markdown
Member

Do we have a Cache buster here? The etag would be perfect,no?

@rullzer

rullzer commented Jan 3, 2019

Copy link
Copy Markdown
Member

Do we have a Cache buster here? The etag would be perfect,no?

Won't help if you embed the image of course.
In general if you refresh the etag will be checked.

@MorrisJobke MorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke

Copy link
Copy Markdown
Member

/backport to stable15

@MorrisJobke MorrisJobke merged commit 211926c into master Jan 3, 2019
@MorrisJobke MorrisJobke deleted the bugfix/13290/cache-public-preview branch January 3, 2019 09:36
@backportbot-nextcloud

Copy link
Copy Markdown

backport to stable15 in #13328

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants