Fix main bundle on IE11#21725
Merged
Merged
Conversation
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
requested review from
ChristophWurst,
marcoambrosini,
nickvergessen,
rullzer and
skjnldsv
Member
Author
|
/backport 5aef97c to stable19 |
Member
does that work? |
nickvergessen
approved these changes
Jul 7, 2020
nickvergessen
left a comment
nickvergessen
left a comment
Member
There was a problem hiding this comment.
Confirmed it fixes the login on IE11
MorrisJobke
approved these changes
Jul 7, 2020
MorrisJobke
left a comment
MorrisJobke
left a comment
Member
There was a problem hiding this comment.
Checke the output and it looks good 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21316
Make sure that properties are always quoted on production builds during terser optimization as unicode properties from our js dependencies are otherwise breaking the main bundle on IE11.