Skip to content

Reuse cache for directory mtime/size if filesystem changes can be ignored#21728

Merged
MorrisJobke merged 1 commit into
masterfrom
bugfix/noid/s3-external-mtime-cache
Jul 15, 2020
Merged

Reuse cache for directory mtime/size if filesystem changes can be ignored#21728
MorrisJobke merged 1 commit into
masterfrom
bugfix/noid/s3-external-mtime-cache

Conversation

@juliusknorr

Copy link
Copy Markdown
Member

For external s3 storages that have the filesystem_check_changes mount option disabled we can assume that the size and mtime from the filecache is valid for directories since in that case no external changes should happen on the s3 storage.

With this the mtime/size of directories will be obtained from the filecache instead of always showing some seconds ago and pending.

…ored

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr added bug 3. to review Waiting for reviews labels Jul 7, 2020

@MorrisJobke MorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense

@MorrisJobke MorrisJobke added this to the Nextcloud 20 milestone Jul 7, 2020
@juliusknorr juliusknorr added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jul 7, 2020
@juliusknorr

Copy link
Copy Markdown
Member Author

Let me have another look here as it seems that the removed delay from #21530 is actually causing the ever updating timestamp and it was not the case before that.

@rullzer

rullzer commented Jul 7, 2020

Copy link
Copy Markdown
Member

But in case of external storage this can still happen right? (that some other app access the external storage).

@juliusknorr

Copy link
Copy Markdown
Member Author

But in case of external storage this can still happen right? (that some other app access the external storage).

Yes, that is why it is only done if the filesystem_check_changes mount option is set to never check external changes.

@rullzer rullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

@MorrisJobke

Copy link
Copy Markdown
Member

@juliushaertl What is pending here?

@juliusknorr

Copy link
Copy Markdown
Member Author

All fine now from my side. I did some more testing and couldn't see any difference in the behavior though the previous timestamp removal.

@juliusknorr juliusknorr added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Jul 15, 2020
@MorrisJobke MorrisJobke merged commit 638e943 into master Jul 15, 2020
@MorrisJobke MorrisJobke deleted the bugfix/noid/s3-external-mtime-cache branch July 15, 2020 16:26
@solracsf

Copy link
Copy Markdown
Member

Will this be backported?

@MorrisJobke

Copy link
Copy Markdown
Member

@juliushaertl @rullzer Are you fine with back porting down to 18?

@juliusknorr

Copy link
Copy Markdown
Member Author

/backport to stable19

@juliusknorr

Copy link
Copy Markdown
Member Author

/backport to stable18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants