Skip to content

Show success on share actions#35271

Merged
szaimen merged 1 commit into
masterfrom
enh/a11y-share-success
Dec 3, 2022
Merged

Show success on share actions#35271
szaimen merged 1 commit into
masterfrom
enh/a11y-share-success

Conversation

@Pytal

@Pytal Pytal commented Nov 18, 2022

Copy link
Copy Markdown
Member

Screenshots

image
image
image
image

@Pytal

Pytal commented Nov 18, 2022

Copy link
Copy Markdown
Member Author

/backport to stable25

Comment thread apps/files_sharing/src/mixins/SharesMixin.js Outdated

@PVince81 PVince81 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 see minor comment, otherwise looks good

@Pytal Pytal force-pushed the enh/a11y-share-success branch from a29ba7f to 16294f0 Compare November 24, 2022 01:48
@Pytal

Pytal commented Nov 24, 2022

Copy link
Copy Markdown
Member Author

/rebase

@JuliaKirschenheuter JuliaKirschenheuter left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool!

@nimishavijay nimishavijay left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal force-pushed the enh/a11y-share-success branch from 0dc2ab8 to 7c943c5 Compare December 3, 2022 01:09
@szaimen szaimen merged commit 31ec83f into master Dec 3, 2022
@szaimen szaimen deleted the enh/a11y-share-success branch December 3, 2022 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants