feat: add confirmation dialog for file extension changes#49308
Conversation
nfebe
force-pushed
the
feat/46528/ask-confirm-extension-change
branch
from
04da216 to
9502ffd
Compare
marcoambrosini
left a comment
marcoambrosini
left a comment
There was a problem hiding this comment.
I would then maybe make the keep action primary instead of the renaming one
It is not destructive (you can revert it) and initialized by the user so as a user I would expect my initiated action to be the primary one. |
It's not destructive for everyone, but for many users that are not very literate it could still be "sort of" destructive if they don't manage to revert it. So I think we should copy macos in this. People who really know what they're doing will follow through the action anyway. 
|
nfebe
force-pushed
the
feat/46528/ask-confirm-extension-change
branch
2 times, most recently
from
fe99148 to
d706aee
Compare
nfebe
left a comment
nfebe
left a comment
There was a problem hiding this comment.
So handled 3 possibilities:
- Adding file extension
- Removing file extension
- Changing file extension
nfebe
force-pushed
the
feat/46528/ask-confirm-extension-change
branch
from
d706aee to
a8a934f
Compare
susnux
added
enhancement
3. to review
- Introduced a dialog to confirm if users want to proceed with changing the file extension. - Added handling for dialog visibility to prevent recursion. (Since it looks like use must press escape to stop rename???) Signed-off-by: nfebe <fenn25.fn@gmail.com>
nfebe
force-pushed
the
feat/46528/ask-confirm-extension-change
branch
from
a8a934f to
383d98c
Compare
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
|
/backport to stable30 |
|
/backport to stable29 |
We do not backport features, no? |
I don't know about that but the reason I back-porting this is because it addressing something that is already experienced in previous versions as we have a github ticket reported. |
6 participants
Resolves : #46528
Screenshot
Checklist