fix(metadata): Correct filesize limit calculation for metadata genera…#54100
Closed
enjeck wants to merge 1 commit into
Closed
fix(metadata): Correct filesize limit calculation for metadata genera…#54100enjeck wants to merge 1 commit into
enjeck wants to merge 1 commit into
Conversation
…tion Signed-off-by: Enjeck C <patrathewhiz@gmail.com>
ArtificialOwl
approved these changes
Jul 28, 2025
Member
|
Superseded by #54951; closing as no longer necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tion
Summary
The value of the
metadata_max_filesizeparameter (or its default value), which is expressed in megabytes, is compared to the file size in bytes for which metadata needs to be generated. However, the conversion from megabytes to bytes is performed by multiplying by 1000000 (1000 * 1000) instead of 1048576 (1024 * 1024).This means that we believe, by default, the system generates metadata for files smaller than 268435456 bytes (256 MB), when in fact, it's for files up to 256000000 bytes (244 MB).
Checklist