Skip to content

docs(config): clarify token_auth_enforced scope and session behavior#61555

Open
joshtrichards wants to merge 3 commits into
masterfrom
jtr/docs-cfg-tokenAuthEnforced
Open

docs(config): clarify token_auth_enforced scope and session behavior#61555
joshtrichards wants to merge 3 commits into
masterfrom
jtr/docs-cfg-tokenAuthEnforced

Conversation

@joshtrichards

@joshtrichards joshtrichards commented Jun 23, 2026

Copy link
Copy Markdown
Member

Summary

Clarify the token_auth_enforced description in config.sample.php.

The updated wording makes it clearer that this option:

  • applies to direct client authentication flows that would otherwise accept either a regular password or an app password/token
  • applies to client-style authentication such as DAV and HTTP Basic auth
  • does not affect the standard interactive browser login, even when the browser is used to authorize a client
  • does not automatically revoke existing sessions when enabled
  • is not the mechanism for restricting password-based browser logins, for which SSO / an external identity provider is the intended approach

Why

The previous wording could be read more broadly than the implementation supports. In practice, this setting applies to direct client credential-based authentication flows, not the standard interactive browser login flow.

It also does not retroactively invalidate existing sessions, so enabling it affects new authentication attempts rather than users with existing authenticated sessions.

Additional context

Related to #50279.

This PR is documentation-only and focuses on clarifying the scope and behavior of token_auth_enforced. Related work in #59569 (unfinished/WIP) addresses separate follow-up work around admin-level session invalidation / revocation tooling.

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI [used to review wording ideas and go rapidly back and forth with numerous drafts I played with to get the wording just right]

Signed-off-by: Josh <josh.t.richards@gmail.com>
@joshtrichards joshtrichards added this to the Nextcloud 35 milestone Jun 23, 2026
@joshtrichards joshtrichards requested a review from a team as a code owner June 23, 2026 19:59
@joshtrichards joshtrichards requested review from Altahrim, ArtificialOwl, icewind1991 and salmart-dev and removed request for a team June 23, 2026 20:00
@joshtrichards joshtrichards added the 3. to review Waiting for reviews label Jun 23, 2026
…ility

Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>

@susnux susnux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be AI assisted, so even though you checked the checkbox as per AI guidelines the commits have to include the AI disclosure:
https://github.com/nextcloud/.github/blob/master/AI_POLICY.md#disclosure

E.g. Assisted-by: ClaudeCode:claude-sonnet-4-6

@susnux susnux added the community pull requests from community label Jun 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews community pull requests from community enhancement feature: authentication

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants