Skip to content

fix(settings): display birthday correctly regardless of browsers timezone#61586

Merged
ChristophWurst merged 2 commits into
masterfrom
BirthdaySection-timezone
Jul 2, 2026
Merged

fix(settings): display birthday correctly regardless of browsers timezone#61586
ChristophWurst merged 2 commits into
masterfrom
BirthdaySection-timezone

Conversation

@odzhychko

@odzhychko odzhychko commented Jun 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

Display birthday correctly regardless of browsers timezone.

Before

Screen.Recording.2026-06-25.at.09.48.23.mov

After

Screen.Recording.2026-06-25.at.09.50.04.mov

Checklist

@odzhychko odzhychko added this to the Nextcloud 34.0.2 milestone Jun 25, 2026
@odzhychko odzhychko added bug 3. to review Waiting for reviews labels Jun 25, 2026
@odzhychko
odzhychko force-pushed the BirthdaySection-timezone branch from 9370ac9 to 08e0100 Compare June 25, 2026 09:05
@odzhychko

odzhychko commented Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

/backport to stable34

@odzhychko

odzhychko commented Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

/backport to stable33

@odzhychko

odzhychko commented Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

/backport to stable32

@odzhychko
odzhychko marked this pull request as ready for review June 25, 2026 10:39
@odzhychko
odzhychko requested review from a team as code owners June 25, 2026 10:39
@odzhychko
odzhychko requested review from nfebe, sorbaugh and susnux and removed request for a team June 25, 2026 10:39
susnux
susnux reviewed Jun 25, 2026
View reviewed changes
Comment thread apps/settings/src/components/PersonalInfo/BirthdaySection.vue Outdated
susnux
susnux reviewed Jun 25, 2026
View reviewed changes
Comment thread apps/settings/src/components/PersonalInfo/BirthdaySection.vue Outdated
susnux
susnux reviewed Jun 25, 2026
View reviewed changes
Comment thread package.json Outdated
susnux
susnux reviewed Jun 25, 2026
View reviewed changes
Comment thread apps/settings/src/components/PersonalInfo/BirthdaySection.spec.js Outdated
@odzhychko
odzhychko force-pushed the BirthdaySection-timezone branch from 08e0100 to 6cdae3c Compare June 26, 2026 15:18
@odzhychko
odzhychko requested a review from susnux June 26, 2026 15:23
@susnux susnux added the community pull requests from community label Jun 27, 2026
@ChristophWurst ChristophWurst removed the community pull requests from community label Jun 30, 2026
@odzhychko
odzhychko requested a review from GVodyanov July 1, 2026 15:18
@odzhychko
odzhychko force-pushed the BirthdaySection-timezone branch from 6cdae3c to 48c4621 Compare July 1, 2026 15:24
susnux
susnux approved these changes Jul 1, 2026
View reviewed changes

@susnux susnux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe this should be a shared composable in nc-vue

odzhychko added 2 commits July 2, 2026 07:12
@odzhychko
refactor(settings): serialize birthday date explicitly
97dcd6c 
`savePrimaryAccountProperty` does only allow  `string | boolean`.
Incidentally, relying on `@nextcloud/axios` default serialization, `Date`s where serialized using `toISOString`.
See https://github.com/axios/axios/blob/a7d7a714498452e611943d9d8e5c2ed8b00aa6b9/lib/helpers/toFormData.js#L134

This change corrects the usage of `savePrimaryAccountProperty` and makes serialization explicit.

Signed-off-by: Oleksandr Dzhychko <hey@oleks.dev>
@odzhychko
fix(settings): display birthday correctly regardless of browsers time…
33ac293 
…zone

This also avoid shifting dates after user input.

Resolves #49828

Signed-off-by: Oleksandr Dzhychko <hey@oleks.dev>
@odzhychko
odzhychko force-pushed the BirthdaySection-timezone branch from 48c4621 to 33ac293 Compare July 2, 2026 05:12
@odzhychko odzhychko added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 2, 2026
@odzhychko

odzhychko commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

maybe this should be a shared composable in nc-vue

Don't know if this is a common enough issue.
Intuitively, I would expect this to be an option on NcDateTimePickerNative rather than a composable.
For example displayUTC.

@ChristophWurst
ChristophWurst merged commit b1edaaa into master Jul 2, 2026
146 of 152 checks passed
@ChristophWurst
ChristophWurst deleted the BirthdaySection-timezone branch July 2, 2026 07:45
This was referenced Jul 2, 2026
Merged
Merged
Closed
@odzhychko

odzhychko commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

/backport to stable34

@backportbot backportbot Bot mentioned this pull request Jul 3, 2026
Merged
3 tasks
@github-actions

github-actions Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnux susnux susnux approved these changes
@skjnldsv skjnldsv skjnldsv approved these changes
@nfebe nfebe Awaiting requested review from nfebe nfebe is a code owner automatically assigned from nextcloud/server-frontend
@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh is a code owner automatically assigned from nextcloud/server-frontend
@GVodyanov GVodyanov Awaiting requested review from GVodyanov

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feedback-requested

Projects

None yet

Milestone

Nextcloud 35

Development

Successfully merging this pull request may close these issues.

[Bug]: entered date is shifted back one day in Birthday

4 participants

@odzhychko @susnux @skjnldsv @ChristophWurst