Skip to content

[stable29] chore: Fix psalm CI on stable29#62400

Open
DerDreschner wants to merge 1 commit into
stable29from
fix/fix-broken-ci
Open

[stable29] chore: Fix psalm CI on stable29#62400
DerDreschner wants to merge 1 commit into
stable29from
fix/fix-broken-ci

Conversation

@DerDreschner

Copy link
Copy Markdown
Contributor

Summary

Since #59840, the static code analysis from psalm is broken in our CI. To make the CI pipeline green again, I've added the correct @since attribute to the function.

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Signed-off-by: David Dreschner <david.dreschner@nextcloud.com>
@DerDreschner DerDreschner self-assigned this Jul 22, 2026
@DerDreschner DerDreschner added 3. to review Waiting for reviews tests Related to tests CI labels Jul 22, 2026
@DerDreschner
DerDreschner enabled auto-merge July 22, 2026 10:38
@DerDreschner
DerDreschner disabled auto-merge July 22, 2026 10:38
@DerDreschner

Copy link
Copy Markdown
Contributor Author

Failing CI runs are unrelated. The one I try to fix with this PR were successful: https://github.com/nextcloud/server/actions/runs/29912665003/job/88899051078?pr=62400

@DerDreschner DerDreschner added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 22, 2026
@DerDreschner

Copy link
Copy Markdown
Contributor Author

@SebastianKrupinski The issues with the other failing tests on stable29 are fixed in #62406. The commit from copilot has nothing to do with what's being fixed here and should be removed to keep the PR clean.

@SebastianKrupinski

Copy link
Copy Markdown
Contributor

@SebastianKrupinski The issues with the other failing tests on stable29 are fixed in #62406. The commit from copilot has nothing to do with what's being fixed here and should be removed to keep the PR clean.

They I must have clicked the copilot button by mistake and didn't realize it. I was just restarting the jobs for you.

@DerDreschner

Copy link
Copy Markdown
Contributor Author

They I must have clicked the copilot button by mistake and didn't realize it. I was just restarting the jobs for you.

All good, I've dropped the commit from copilot. Just wanted to let you know and see if that was on purpose or not. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish CI tests Related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants