fix: Don't add empty and broken ExternalShareScanJob on upgrade#62412
Merged
Conversation
This is added manually in apps/files_sharing/lib/Controller/ExternalSharesController.php when needed and with arguments. Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
requested review from
a team,
nfebe,
provokateurin and
skjnldsv
as code owners
July 22, 2026 13:39
CarlSchwan
requested review from
Altahrim and
icewind1991
and removed request for
a team
July 22, 2026 13:39
CarlSchwan
enabled auto-merge
July 22, 2026 20:49
nickvergessen
approved these changes
Jul 22, 2026
provokateurin
approved these changes
Jul 23, 2026
Member
Author
|
/backport to stable34 |
Member
Author
|
/backport to stable33 |
Member
Author
|
/backport to stable32 |
|
The backport to # Switch to the target branch and update it
git checkout stable32
git pull origin stable32
# Create the new backport branch
git checkout -b backport/62412/stable32
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick f7da7e6b
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/62412/stable32Error: Failed to check for changes with origin/stable32: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is added manually in
apps/files_sharing/lib/Controller/ExternalSharesController.php when needed and with arguments.
Summary
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)