Skip to content

update deps#48

Merged
jdalton merged 1 commit into
nirgit:masterfrom
jdalton:jdalton/update-deps
May 5, 2024
Merged

update deps#48
jdalton merged 1 commit into
nirgit:masterfrom
jdalton:jdalton/update-deps

Conversation

@jdalton

@jdalton jdalton commented Apr 30, 2024

Copy link
Copy Markdown
Collaborator

update deps

@jdalton jdalton force-pushed the jdalton/update-deps branch 2 times, most recently from 97cfc05 to c6fa6b7 Compare April 30, 2024 21:15
@jdalton jdalton force-pushed the jdalton/update-deps branch from c6fa6b7 to bb10fad Compare May 1, 2024 15:14

@nirgit nirgit left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool. PR looks good @jdalton 👍

two things before we merge this PR:

  1. fix the build which now fails (npm run build)
  2. see comment re unused dependency (dont forget to rebuild the package-lock after removal)

Comment thread .gitignore
Comment thread package.json Outdated
@jdalton jdalton force-pushed the jdalton/update-deps branch from bb10fad to e339aa3 Compare May 3, 2024 15:34
@jdalton

jdalton commented May 3, 2024

Copy link
Copy Markdown
Collaborator Author

Updated with issues fixed.

@nirgit

nirgit commented May 4, 2024

Copy link
Copy Markdown
Owner

lgtm @jdalton

@jdalton

jdalton commented May 5, 2024

Copy link
Copy Markdown
Collaborator Author

Okay! @nirgit I lack merge rights, so I cannot merge.

@nirgit

nirgit commented May 5, 2024

Copy link
Copy Markdown
Owner

Okay! @nirgit I lack merge rights, so I cannot merge.

sent you an invite, after you accept, i'll set up the relevant permissions (AFAIR)

@jdalton jdalton merged commit 2840009 into nirgit:master May 5, 2024
@jdalton jdalton deleted the jdalton/update-deps branch May 5, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants