v2 release discussion

[GrosSacASac]

Creating this issue to have one place to discuss the v2 release.

I think that we should clean up the changelog. By that I mean remove from the changelog everything that is noise for the average formidable user. For example >" refactor: use hasOwnProperty in check against files/fields" is not useful information for someone that is trying to migrate from v1 to v2. If you agree I can make a PR for that.

First time since a long time that we are under 30 open issues 🥇 .

Ideally we also

• fix the tests (they broke since I migrated to Jest a bit too fast).
• create a migration guide

[tunnckoCore]

Agree. These are noise. The beginning is good. They have links to all the issues and PRs to see how much work is done.

Migration guide is nothing more than the exports change. Oh yea, and the plugins API and the cool fileWriteStream handling.

[karlhorky]

From my comment here: #635 (comment)

I guess #689 was merged and then the filter PR #716 was also merged, right? I guess that means a v2 release sometime in the next few weeks?

Is this true? Would a v2 release be sometime in the next weeks?

[karlhorky]

• fix the tests (they broke since I migrated to Jest a bit too fast).

Which tests are broken? Everything on GitHub Actions that's failing on the master branch?

https://github.com/node-formidable/formidable/runs/2249456170

Would be good to have a clear list of open tasks and how to attack them, just in case anyone (eg. @songkeys) would like to contribute here.

[GrosSacASac]

Which tests are broken? Everything on GitHub Actions that's failing on the master branch?

Fixtures. When you try to run tests locally you can see.

Is this true? Would a v2 release be sometime in the next weeks?

Soon ™ lol

[GrosSacASac]

https://ko-fi.com/tunnckoCore Everyone get in

[GrosSacASac]

@tunnckoCore publish v2 whenever you are ready, I am going to start the v3 branch soon

[GrosSacASac]

ideally sooner than later because most people assume npm contains the last version and create issue like this #726 , #736

And on stackoverflow there are a lot of people still on v1

[fwh1990]

Expect to see v2 released in these days, and don't forget to upgrade @types/formidable as well.

[karlhorky]

Yeah, @types/formidable are currently broken with the 1.2.2 version (which means they'll be also broken for v2), after the PR from @peterblazejewicz and @martin-badin :

DefinitelyTyped/DefinitelyTyped#51364 (comment)

[peterblazejewicz]

@karlhorky
We can revert the 1.2.2 changes or the conflicting change can be fixed by PR. I'd nt say types are broken.