Skip to content

Added support for uploading files to buffer instead of filesystem#267

Closed
Elzair wants to merge 11 commits into
node-formidable:masterfrom
Elzair:master
Closed

Added support for uploading files to buffer instead of filesystem#267
Elzair wants to merge 11 commits into
node-formidable:masterfrom
Elzair:master

Conversation

@Elzair

@Elzair Elzair commented Jan 2, 2014

Copy link
Copy Markdown

A while ago, I encountered a problem uploading images >1MB to a Nodejitsu instance. I assume that cloud hosting providers like Nodejitsu do not always support a large filesystem for node.js instances. Since I needed to upload the file to the server before pushing it to an image hosting service, I modified node-formidable to support uploading files to Buffers instead of to the filesystem.

@felixge

felixge commented Jan 3, 2014

Copy link
Copy Markdown
Collaborator

Hi @Elzair - thanks for this contribution. I have to admit that I'm a little hesitant when it comes to merging this, as the desired functionality can be provided in userland as well (by defining your own form.onPart = function(part) { handler).

Do you see any compelling reasons why this should be part of formidable itself?

@tunnckoCore

tunnckoCore commented Jan 29, 2020

Copy link
Copy Markdown
Member

@Elzair thanks! A bit late here, but if you still using formidable library or want similar thing check out with npm i formidable@canary - preview of v2 release.

Also, there are issues that want this feature, and if couldn't land at v2, it will be possible to the user to do whatever he want because the #545 Plugin API. Also, because the reason that v2 exports everything - all the parser classes, all the plugins, all the utils, aliases and etc.

I'm going to close this, because it's based on pretty old code base.
But I'll add you with Co-authored-by.

@node-formidable node-formidable deleted a comment from allcontributors Bot Jan 29, 2020
@tunnckoCore

Copy link
Copy Markdown
Member

@all-contributors please add @Elzair for code and idea

@allcontributors

Copy link
Copy Markdown
Contributor

@tunnckoCore

I've put up a pull request to add @Elzair! 🎉

@Elzair

Elzair commented Feb 4, 2020

Copy link
Copy Markdown
Author

Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants