Added image tags for major versions - #526
Open
simonjamain wants to merge 1 commit into
Open
Conversation
|
|
simonjamain
commented
Jul 27, 2026
| PUSH=true | ||
| VERSION=${TRAVIS_TAG:1} | ||
| STABLE_VERSION=`echo ${VERSION} | sed -r 's/^([[:digit:]]+)\.([[:digit:]]+)\.([[:digit:]]+)$/\1.\2/'` | ||
| MAJOR_VERSION=`echo ${VERSION} | sed -r 's/^([[:digit:]]+)\.([[:digit:]]+)\.([[:digit:]]+)$/\1/'` |
Author
There was a problem hiding this comment.
I tried to keep your regex logic that explicits the whole expected input and just select the relevant parts, that also makes it easy to compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #525
Proposed changes
see #525 for the origin
The introduction of a new registry tag holding only the major version (keeping and ofc) to allow easy tracking of major changes only.
Examples of images with this principle :
nginx : https://hub.docker.com/layers/library/nginx/1
traefik : https://hub.docker.com/layers/library/traefik/3
Checklist
gruntto verify the unit tests pass (N/A, I don't think that any tests are covering those tags)