Do not append an identical file extension#1328
Closed
bourgeoa wants to merge 2 commits into
Closed
Conversation
Member
Author
|
@RubenVerborgh I checked that I have the same test errors with and without the fix. |
| return extension && this._types[extension[1].toLowerCase()] || this._defaultContentType | ||
| } | ||
|
|
||
| // hack to fix file.ext$.ext --> file.ext |
Contributor
There was a problem hiding this comment.
Let's not do hacks in this class that's actually in good shape 😉
RubenVerborgh
approved these changes
Oct 23, 2019
Contributor
RubenVerborgh
left a comment
RubenVerborgh
left a comment
There was a problem hiding this comment.
Thanks! Kept test; replaced with non-hack.
RubenVerborgh
changed the title
Contributor
|
Continued in #1336 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1318
Problem identified in jshttp/mime-types#23