Skip to content

Request a token for node-gyp#935

Merged
legendecas merged 2 commits into
nodejs:mainfrom
legendecas:node-gyp
Jan 28, 2025
Merged

Request a token for node-gyp#935
legendecas merged 2 commits into
nodejs:mainfrom
legendecas:node-gyp

Conversation

@legendecas

@legendecas legendecas commented Dec 3, 2024

Copy link
Copy Markdown
Member

Refs: nodejs/node-gyp#3105

permissions:
  contents: write
  pull-requests: write

@legendecas legendecas mentioned this pull request Dec 3, 2024
Merged
1 task
mhdawson
mhdawson approved these changes Dec 10, 2024
View reviewed changes

@mhdawson mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mhdawson
mhdawson reviewed Jan 28, 2025
View reviewed changes
Comment thread request-an-access-token.md Outdated
@mhdawson

mhdawson commented Jan 28, 2025

Copy link
Copy Markdown
Member

@legendecas token created/added

@legendecas @mhdawson
Update request-an-access-token.md
8e0ec91 
Co-authored-by: Michael Dawson <mdawson@devrus.com>
@legendecas

legendecas commented Jan 28, 2025

Copy link
Copy Markdown
Member Author

Thanks!

@legendecas
legendecas merged commit 46ee242 into nodejs:main Jan 28, 2025
@legendecas
legendecas deleted the node-gyp branch January 28, 2025 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
+1 more reviewer
@mhdawson mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@legendecas @mhdawson @jasnell