jenkins: skip SmartOS and AIX for pull request test runs - #4458
Open
codebytere wants to merge 1 commit into
Open
jenkins: skip SmartOS and AIX for pull request test runs#4458codebytere wants to merge 1 commit into
codebytere wants to merge 1 commit into
Conversation
node-test-pull-request passes GIT_REMOTE_REF=refs/pull/N/head down to every sub-job, while node-daily-* and release jobs pass a branch ref. Use that to exclude the smartos and aix labels from PR-triggered test runs only, so those jobs stop queueing 2-3 h per PR on a single executor while daily and release CI keep full Tier 2 coverage. Refs: nodejs#4457 Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com>
richardlau
requested changes
Sep 6, 2026
richardlau
left a comment
Member
There was a problem hiding this comment.
I object to removing AIX from pull request test jobs (since we release binaries for it), but putting that to one side, this isn't the best way to exclude platforms from PR CIs as the parent jobs will still be run (this only exclude the matrix axes).
For e.g. IBM i (which is not run on PRs), we do not include the job in the node-test-pull-request Multijob and instead include it in node-daily-master.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the proposal in #4457 in the one place this repo controls,
VersionSelectorScript.groovy.node-test-pull-requestpassesGIT_REMOTE_REF=refs/pull/N/headdown throughnode-test-committo every sub-job, whilenode-daily-*,node-release-candidateand the other upstream triggers pass a branch ref (checked against the parameters of recentnode-test-commit-smartosbuilds from both). This adds aprTestTypepredicate keyed on that and excludes thesmartos*andaix7*labels for PR-triggered test runs only.node-test-commit-smartosand-aixare still triggered by the multijob but select no configurations, which the matrix strategy reports as SUCCESS within seconds (BaseMES.runstarts from SUCCESS and only folds in configuration results); daily, staging-daily and release runs are unchanged.Dry-ran the script with emulated
parameters/combinationsbindings: a v27 PR run keepsrhel8-x64,macos15-x64,rhel9-s390xand dropssmartos23-x64,aix72-power9,aix73-power9; the same labels withrefs/heads/main, with no ref, or withbuildType = 'release'keep everything. What i couldn't check from outside is whether either job has a parent-level post-build step that objects to zero configurations (a JUnit publisher, say); if so that wants "do not fail on empty results" alongside this.Refs: #4457
Disclosure: the code and this description were written by Claude Code, directed and reviewed by @codebytere.