lookup: mark got as skip on all versions - #795
Merged
Merged
Conversation
This was referenced Sep 9, 2020
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Got seems to be failing on all Node.js versions across all platforms with:
Details
got@10.6.0 test /Users/bethgriggs/got
xo && tsc --noEmit && nyc ava
parseForESLintfrom parser@typescript-eslint/parseris invalid and will just be ignoredsource/normalize-arguments.ts:46:1
⚠ 46:1 Unexpected todo comment. no-warning-comments
⚠ 47:38 Arrow function has a complexity of 49. Maximum allowed is 20. complexity
⚠ 320:2 Unexpected todo comment. no-warning-comments
⚠ 375:42 Async arrow function has a complexity of 57. Maximum allowed is 20. complexity
⚠ 383:3 Unexpected todo comment. no-warning-comments
source/request-as-event-emitter.ts:59:26
⚠ 59:26 Async arrow function has a complexity of 23. Maximum allowed is 20. complexity
source/types.ts:63:1
⚠ 63:1 Unexpected todo comment. no-warning-comments
source/utils/options-to-url.ts:41:16
⚠ 41:16 Arrow function has a complexity of 21. Maximum allowed is 20. complexity
source/utils/url-to-options.ts:4:1
⚠ 4:1 Unexpected todo comment. no-warning-comments
test/timeout.ts:13:33
⚠ 430:1 Unexpected todo comment. no-warning-comments
⚠ 588:1 Unexpected todo comment. no-warning-comments
⚠ 602:1 Unexpected todo comment. no-warning-comments
✖ 13:33 Parse errors in imported module ../source: Cannot read property name of undefined (undefined:undefined) import/namespace
✖ 13:33 Parse errors in imported module ../source: Cannot read property name of undefined (undefined:undefined) import/default
✖ 13:33 Parse errors in imported module ../source: Cannot read property name of undefined (undefined:undefined) import/no-named-as-default-member
✖ 13:33 Parse errors in imported module ../source: Cannot read property name of undefined (undefined:undefined) import/no-named-as-default
...
test/helpers/types.ts:4:19
✖ 4:19 Parse errors in imported module ../../source: Cannot read property name of undefined (undefined:undefined) import/namespace
14 warnings
83 errors
npm ERR! Test failed. See above for more details.