chore(ci): enable Node.js 24 ci tests for Windows - #896
Merged
Conversation
Signed-off-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
Contributor
Author
|
CI tests under Windows under GitHub Actions are taking a long time compared to running locally. Node.js 22 / Windows has timed out. I already ran the workflow successfully in my own fork, so I suspect if the failed workflow is re-run, then it would succeed. |
aduh95
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Situation
Workflow .github/workflows/ci.yml currently excludes ci tests from running under the combination of Node.js 24 and
windows-latest.A bug in Node.js, that was fixed through nodejs/node#61999, prevented tests on Node.js >24 from running reliably.
nodejs/node#61999 was released in:
The GitHub Actions runner image
windows-latest, used by the workflow, is an alias for windows-2025-vs2026. Image version20260907.229.1(fully deployed on Sep 11, 2026) caches:This meets the prerequisite minimum Node.js 24.20.0 requirement.
Change
In .github/workflows/ci.yml, remove the exclusion for ci tests running under the combination of Node.js 24 and
windows-latest. Windows tests will then run under each of the supported Node.js release lines: 22, 24 & 26.