fix: confine code block horizontal scrolling to the code - #1086
Open
OmerDavidson wants to merge 1 commit into
Open
fix: confine code block horizontal scrolling to the code#1086OmerDavidson wants to merge 1 commit into
OmerDavidson wants to merge 1 commit into
Conversation
`pre` was the scroll container, so a long line scrolled the whole code block, taking the toolbar (language label and copy button) out of view with it. Move `overflow-x: auto` down to the `code` element so only the code scrolls. Shiki's `tabindex="0"` moves along with it, otherwise the scrollable region stops being reachable by keyboard. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018dS1J3EZzqhxBCc6wmh8Vj
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When scrolling horizontally, the footer scrolls too.
This PR fixes that
prewas the scroll container for code blocks, so a single long line scrolled the whole block — taking the toolbar (language label and copy button) out of view with it. This movesoverflow-x: autodown to thecodeelement so only the code scrolls.Shiki puts
tabindex="0"on the<pre>so the scrollable region is keyboard-reachable; that moves to the<code>element along with the scrolling, otherwise it is left on an element that no longer scrolls.