Skip to content

update -h script help option non-working examples #2412

Description

@MikeMcC399

Environment

  • Platform: Ubuntu 24.04.4 LTS
  • Docker Version: N/A
  • Node.js Version: N/A
  • Image Tag: N/A

Expected Behavior

The help text, which is invoked with ./update.sh -h, should provide a list of working commands.

Current behavior

The help text is as follows:

$ ./update.sh -h

  Update the node docker images.

  Usage:
    ./update.sh [-s] [MAJOR_VERSION(S)] [VARIANT(S)]

  Examples:
    - update.sh                      # Update all images
    - update.sh -s                   # Update all images, skip updating Alpine if the musl build isn't available
    - update.sh 8,10                 # Update all variants of version 8 and 10
    - update.sh -s 8                 # Update version 8 and variants, skip updating Alpine if the musl build isn't available
    - update.sh 8 alpine             # Update only alpine's variants for version 8
    - update.sh -s 8 bullseye        # Update only bullseye variant for version 8, skip updating Alpine if the musl build isn't available
    - update.sh . alpine             # Update the alpine variant for all versions

  OPTIONS:
    -s Security update; skip updating the Alpine versions.
    -h Show this message

  1. Using alpine as an argument, as in ./update.sh . alpine, does not target alpine variants. Instead it updates all Alpine and Debian variants.
  2. The text for bullseye does not mention that bullseye-slim will not be targeted, although this might be expected.
  3. Using the Node.js versions 8 & 10 causes all active Node.js versions to be updated. Node.js 8 & 10 are already in EOL status.

Possible Solution

Update the help text in update.sh

  • use Node.js 22 & 24 as example versions
  • use alpine3.23 as an example
  • include both trixie and trixie-slim as separate Debian variant examples

Steps to Reproduce

git clone https://github.com/nodejs/docker-node
cd docker-node

Execute each of the examples, observe the logs and check the changes made (git diff)

Additional Information

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions