Skip to content

doc: add collaborator guide #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mmarchini wants to merge 2 commits into from
Closed

doc: add collaborator guide #273

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
935cffc
doc: add collaborator guide
mmarchini Feb 26, 2019
a6e3e75
fixup! doc: add collaborator guide
mmarchini Mar 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions COLLABORATOR_GUIDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
# llnode Collaborator Guide

llnode follows
[Node.js Collaborator Guide](https://github.com/nodejs/node/blob/master/COLLABORATOR_GUIDE.md),
with the following exception:

llnode Collaborators are allowed to approve their own Pull Requests if it has
been opened for at least 7 days and there was no reviews from other

@cjihrig cjihrig Feb 26, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really like this idea. However, if this does land, please add text about requiring a passing CI run.

@mmarchini mmarchini Feb 26, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is covered by the Node.js Collaborators Guide, but I can make it explicit here too.

@sam-github sam-github Feb 26, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just say something to the effect of "All other landing criteria still have to be met even if its self-approved." rather than repeating the criteria.

Is it really that hard to get approval on PRs here? llnode is pretty important now that its almost our default http parser, I'd hope it gets more attention than that. Could the exception be removed, and the issue of lack of active collabs be brought up to the TSC level, or equivalent?

@mmarchini mmarchini Feb 26, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just say something to the effect of "All other landing criteria still have to be met even if its self-approved." rather than repeating the criteria.

I like that. I'll make the change.

Is it really that hard to get approval on PRs here?

Medium and large changes tend to take a month or more to get reviewed.

llnode is pretty important now that its almost our default http parser, I'd hope it gets more attention than that.

I think you're referring to https://github.com/nodejs/llhttp. llnode is unrelated to HTTP parsing.

@sam-github sam-github Feb 26, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I absolutely misread, sorry!

collaborators. All other landing criteria still have to be met even if its
self-approved.