Drop Node.js v0.8.x from Travis CI.#826
Merged
Merged
Conversation
Member
Author
node-gyp v3.6.3 doesn't work with node.js v0.8.28 any longer and therefore the test suite doesn't build. As that is outside our control, drop it. In fact, it's a dependency of node-gyp that stopped working but that is immaterial, the net result is the same. PR-URL: #826 Reviewed-By: David Siegel <agnat@me.com>
Member
Author
|
Thanks! |
This was referenced Nov 15, 2018
amitparida
added a commit
to amitparida/npm-nan
that referenced
this pull request
Oct 3, 2024
node-gyp v3.6.3 doesn't work with node.js v0.8.28 any longer and therefore the test suite doesn't build. As that is outside our control, drop it. In fact, it's a dependency of node-gyp that stopped working but that is immaterial, the net result is the same. PR-URL: nodejs/nan#826 Reviewed-By: David Siegel <agnat@me.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
node-gyp v3.6.3 doesn't work with node.js v0.8.28 any longer and
therefore the test suite doesn't build. As that is outside our
control, drop it.
In fact, it's a dependency of node-gyp that stopped working but
that is immaterial, the net result is the same.