fix: handle double quotes inside single-quoted GYP strings#3346
Open
bitpshr wants to merge 1 commit into
Open
Conversation
parseConfigGypi() converted single quotes to double quotes with a bare `config.replace(/'/g, '"')`, which produced invalid JSON when a single-quoted string contained double-quote characters, such as the GYP condition strings used by native addons (e.g. `'OS=="win"'`). Convert each single-quoted string individually and escape the double quotes inside it instead. Fixes: nodejs#3333 Signed-off-by: Paul Bouchon <mail@bitpshr.net>
bitpshr
force-pushed
the
fix/gyp-config-double-quotes
branch
from
July 20, 2026 22:13
3b1abb1 to
cf18d58
Compare
Author
|
Rebased this onto main to pick up the undici 8.7.0 fix from #3345, which looks like what was causing the Windows + Node 26 @legendecas the CI run is sitting in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3333.
parseConfigGypi()converted single quotes to double quotes with a bareconfig.replace(/'/g, '"'), which produced invalid JSON whenever a single-quoted string contained"(e.g. GYP condition strings like'OS=="win"', used by native addons such as canvas). It now converts each single-quoted string individually and escapes the double quotes inside it. Added a regression test.