aix: embedded-builtins generated code doesn't compile

[refack]

• Version: V8 7.1
• Platform: AIX

  ccache /home/iojs/gcc-6.3.0-1/opt/freeware/bin/g++ '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=0' '-DV8_TARGET_ARCH_PPC' '-DV8_TARGET_ARCH_PPC64' '-DV8_TARGET_ARCH_PPC_BE' '-D_LINUX_SOURCE_COMPAT=1' '-D__STDC_FORMAT_MACROS' '-D_ALL_SOURCE=1' '-DV8_EMBEDDER_STRING="-node.0"' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT' '-Dv8_promise_internal_field_count' '-DV8_INTL_SUPPORT' '-DV8_CONCURRENT_MARKING' '-DDISABLE_UNTRUSTED_CODE_MITIGATIONS' '-DV8_EMBEDDED_BUILTINS' '-DV8_EMBEDDED_BYTECODE_HANDLERS' '-DUCONFIG_NO_SERVICE=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' -I../deps/v8 -I../. -I/home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/out/Release/obj/gen -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common  -pthread -Wall -Wextra -Wno-unused-parameter -maix64 -mcpu=power5+ -mfprnd -mno-popcntb -fno-strict-aliasing -maix64 -fdollars-in-identifiers -fdata-sections -ffunction-sections -O3 -O3 -fno-omit-frame-pointer -fno-rtti -fno-exceptions -std=gnu++1y -MMD -MF /home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/out/Release/.deps//home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/out/Release/obj.target/v8_snapshot/geni/embedded_default.o.d.raw   -c -o /home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/out/Release/obj.target/v8_snapshot/geni/embedded_default.o /home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/out/Release/obj.target/v8_snapshot/geni/embedded_default.cc
Assembler:
/tmp//cc3CI28B.s: line 11: 1252-016 The specified opcode or pseudo-op is not valid.
	Use supported instructions or pseudo-ops only.
/tmp//cc3CI28B.s: line 12: 1252-016 The specified opcode or pseudo-op is not valid.
	Use supported instructions or pseudo-ops only.
/tmp//cc3CI28B.s: line 13: 1252-016 The specified opcode or pseudo-op is not valid.
	Use supported instructions or pseudo-ops only.
/tmp//cc3CI28B.s: line 14: 1252-016 The specified opcode or pseudo-op is not valid.
	Use supported instructions or pseudo-ops only.
/tmp//cc3CI28B.s: line 15: 1252-016 The specified opcode or pseudo-op is not valid.
	Use supported instructions or pseudo-ops only.

embedded_default.cc.txt

[richardlau]

cc @nodejs/platform-aix

[mhdawson]

@john-yan can you take a look at this.

[V-for-Vasili]

@mhdawson @refack We have found out that embedded builtins do not work correctly on Aix and they were temporarily disabled (for gn build) in this patch: https://chromium-review.googlesource.com/c/v8/v8/+/1168085

This change does not affect GYP build.

[refack]

This change does not affect GYP build.

@V-for-Vasili thanks. I will manually reflect this in the GYP scaffolding.

I'd like to keep this issue open, so we'll track when/if this is actually solved.

[targos]

Fixed in nodejs/node#22920

[refack]

Do we want to keep track of this, since it wasn't actually fixed, rather disabled as a temporary workaround?

[targos]

I think we can keep this closed. We will enable it when V8 does

[mhdawson]

From my understanding from @V-for-Vasili the gap in AIX will result in slower code but not functional problems. Given that I think its ok to close and then things will speed up once we close the gap and the tests will be re-enabled when we either float the required changes or move up to a new v8 level.

[hashseed]

Not supporting embbeded builtins on AIX will become a deal breaker soon. We are planning to remove support for non-embedded builtins and that will break AIX. See https://bugs.chromium.org/p/v8/issues/detail?id=8043

[targos]

Thanks for the update @hashseed. I'll reopen for more visibility.

[mhdawson]

From talking with @V-for-Vasili we should see a PR to V8 to add support soon on AIX.

[targos]

It's done