Broken build on Windows

[targos]

https://ci.nodejs.org/job/node-compile-windows/22413/label=win-vs2017/console

Error:

09:37:30 v8_base_0.lib(isolate.obj) : error LNK2001: unresolved external symbol v8_Default_embedded_blob_ [c:\workspace\node-compile-windows\node.vcxproj]
09:37:30 v8_base_0.lib(isolate.obj) : error LNK2001: unresolved external symbol v8_Default_embedded_blob_size_ [c:\workspace\node-compile-windows\node.vcxproj]
09:37:30 c:\workspace\node-compile-windows\Release\node.exe : fatal error LNK1120: 2 unresolved externals [c:\workspace\node-compile-windows\node.vcxproj]

[refack]

@targos do you know which change made this regression?

[targos]

@refack Probably this change: v8/v8@bd8ed720cfa
Corresponding gypfile update: 0b2a344

[refack]

Thanks. I think it's a GYP bug (it does not map .S files as proper files to compile).
On it.

[bzoz]

FWIW manually changing embedded.S file type fixes compilation:

[bzoz]

Got it working, a GYP issue:

diff --git a/tools/gyp/pylib/gyp/generator/msvs.py b/tools/gyp/pylib/gyp/generator/msvs.py
index 8fe9e5af23..ba585b1bfc 100644
--- a/tools/gyp/pylib/gyp/generator/msvs.py
+++ b/tools/gyp/pylib/gyp/generator/msvs.py
@@ -2171,6 +2171,9 @@ def _MapFileToMsBuildSourceType(source, rule_dependencies,
   elif ext == '.asm':
     group = 'masm'
     element = 'MASM'
+  elif ext == '.S':
+    group = 'masm'
+    element = 'MASM'
   elif ext == '.idl':
     group = 'midl'
     element = 'Midl'

[refack]

Thanks @bzoz! that's the patch I came up with as well.

[bzoz]

PR with fix: nodejs/node#24553

[refack]

So FTR windows-32 is a different error:

08:44:22 c:\workspace\node-compile-windows\deps\v8\src/ia32/assembler-ia32-inl.h(282): error C2440: '?': cannot convert from 'v8::internal::Code' to 'bool' (compiling source file ..\src\snapshot\startup-deserializer.cc) [c:\workspace\node-compile-windows\deps\v8\gypfiles\v8_base_2.vcxproj]
08:44:22   c:\workspace\node-compile-windows\deps\v8\src/ia32/assembler-ia32-inl.h(282): note: Ambiguous user-defined-conversion (compiling source file ..\src\snapshot\startup-deserializer.cc)
08:44:22 c:\workspace\node-compile-windows\deps\v8\src/ia32/assembler-ia32-inl.h(281): error C2660: 'v8::internal::Assembler::set_target_address_at': function does not take 2 arguments (compiling source file ..\src\snapshot\startup-deserializer.cc) [c:\workspace\node-compile-windows\deps\v8\gypfiles\v8_base_2.vcxproj]

[vsemozhetbyt]

Still no Windows binaries in the last build?
https://nodejs.org/download/v8-canary/v12.0.0-v8-canary2018120142ec383074/

[targos]

@ryzokuken fixed the canary branch today. Should be fine in the next build