test: flaky - parallel/test-pipe-stream

[refack]

• Version: master
• Platform: freeBSD
• Subsystem: test,stream

not ok 912 parallel/test-pipe-stream
  ---
  duration_ms: 3.136
  severity: fail
  stack: |-
    events.js:182
          throw er; // Unhandled 'error' event
          ^
    
    Error: listen EADDRINUSE /usr/home/iojs/node-tmp/tmp.1/test.sock
        at Object.exports._errnoException (util.js:1023:11)
        at exports._exceptionWithHostPort (util.js:1046:20)
        at Server.setupListenHandle [as _listen2] (net.js:1302:19)
        at listenInCluster (net.js:1367:12)
        at Server.listen (net.js:1478:5)
        at test (/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd10-64/test/parallel/test-pipe-stream.js:56:10)
        at /usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd10-64/test/parallel/test-pipe-stream.js:66:3
        at Server.<anonymous> (/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd10-64/test/parallel/test-pipe-stream.js:61:11)
        at emitNone (events.js:105:13)
        at Server.emit (events.js:207:7)
  ...

https://ci.nodejs.org/job/node-test-commit-freebsd/10201/nodes=freebsd10-64/

[refack]

/cc @nodejs/platform-freebsd @nodejs/streams

[mcollina]

The problem starts because we are not rotating/changing common.PIPE and https://github.com/nodejs/node/blob/master/test/common/index.js#L259-L266.
If there is another process left there, or if that is not cleaned up correctly, this will fail.

This should be done by https://github.com/nodejs/node/blob/master/test/common/index.js#L156-L159 called from https://github.com/nodejs/node/blob/master/test/parallel/test-pipe-stream.js#L6, but it seems not happening on freebsd.

[refack]

The problem starts because we are not rotating/changing common.PIPE

@mcollina tl;dr you think best solution is for common to rotate common.PIPE? If yes, I'll open a PR.

[mcollina]

Yes, I think so. Or to do one based on the process PID.

[refack]

PR #14168 (Untested) CI ✔️