-
-
Notifications
You must be signed in to change notification settings - Fork 37.2k
Run linters before running tests? #16283
Copy link
Copy link
Closed
Labels
buildIssues and PRs related to Node.js builds or CI infrastructure.Issues and PRs related to Node.js builds or CI infrastructure.discussIssues opened for discussion and feedback.Issues opened for discussion and feedback.testIssues and PRs related to Node.js core tests and test infrastructure.Issues and PRs related to Node.js core tests and test infrastructure.toolsIssues and PRs related to the tools directory.Issues and PRs related to the tools directory.
Description
Activity
Metadata
Metadata
Assignees
Labels
buildIssues and PRs related to Node.js builds or CI infrastructure.Issues and PRs related to Node.js builds or CI infrastructure.discussIssues opened for discussion and feedback.Issues opened for discussion and feedback.testIssues and PRs related to Node.js core tests and test infrastructure.Issues and PRs related to Node.js core tests and test infrastructure.toolsIssues and PRs related to the tools directory.Issues and PRs related to the tools directory.
When there are flaky errors
make lintwould not be run, so one has to manually trigger them, and it's easy to forget. I think this is pretty common because we have PRs failing linter CIs on the first run from time to time. Maybe we can run the linter before running the tests?