Skip to content

Need to update source exclusions for ICU 61 #16937

Description

@srl295
  • Platform: all
  • Subsystem: deps

#16876 landed ICU 60.1 but didn't update the source exclusions in icu_generic.gyp. As a result:

  • too many files are built- increases binary size, and source size (this also controls what is checked into the repo)
  • there's more exposure for platform build issues (probably a minor point)

This would cause NO change in actual behavior, because the files aren't actually executed (or their removal would have caused the build to fail).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

c++Issues and PRs that require attention from people who are familiar with C++.i18n-apiIssues and PRs related to Node.js internationalization support.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions