-
-
Notifications
You must be signed in to change notification settings - Fork 37.1k
Removing the bench-* targets in makefile? #17053
Copy link
Copy link
Closed
Labels
benchmarkIssues and PRs related to Node.js benchmarks and benchmarking infrastructure.Issues and PRs related to Node.js benchmarks and benchmarking infrastructure.buildIssues and PRs related to Node.js builds or CI infrastructure.Issues and PRs related to Node.js builds or CI infrastructure.discussIssues opened for discussion and feedback.Issues opened for discussion and feedback.
Description
Activity
Metadata
Metadata
Assignees
Labels
benchmarkIssues and PRs related to Node.js benchmarks and benchmarking infrastructure.Issues and PRs related to Node.js benchmarks and benchmarking infrastructure.buildIssues and PRs related to Node.js builds or CI infrastructure.Issues and PRs related to Node.js builds or CI infrastructure.discussIssues opened for discussion and feedback.Issues opened for discussion and feedback.
Hi all, just wondering is there anyone actually using the bench-* targets in the Makefile? This is not used by the benchmark CI, and basically those just call
./node benchmark/run.js *which is not really that hard to remember (and this does not even allow you to set the arguments at all. Besides, these days we tend to usebenchmark/compare.jsinstead). Thebench-allandbenchtarget somehow only run a subset of the benchmarks and they are not covering all the categories that we have anyway. Based on this I think those are not maintained and not really used anymore so I am just wondering maybe we can remove those altogether.Refs: #16934